search

verigak / progress

Easy to use progress bars for Python
ISC License
1.41k stars 179 forks source link

Program abrupt termination (^C) should reset cursor state #64

Closed clintolsen closed 5 years ago

clintolsen commented 5 years ago

Since progress hides the cursor, if the program exits/crashes prematurely or is interrupted via the keyboard, the cursor state is left in the hidden mode. Some attempt should be made to restore this state under most circumstances.

frasern commented 5 years ago

Pull request #69 should resolve this.

set-leanix commented 5 years ago

Any progress on reviewing the related PR? I really like this library but this issue is a real deal breaker unfortunately. I also tested the PR locally. It works fine and the code looks fine too.

set-leanix commented 5 years ago

Thanks @verigak is there a release planned for this soon?

verigak commented 5 years ago

There isn't a lot of stuff since last release yet and in any case I like to leave a small period of time in case any bugs come up. Ping me up again in a couple weeks and I'll do a release then.

set-leanix commented 5 years ago

Why not doing a patch level release 1.5.1 then? I can gladly help out but it's a mere version bump, python setup.py bdist_wheel and twine upload dist/*. Why wait for weeks with that?

luliangce commented 4 years ago

according the atexit‘s doc, it cannot reslove problem sometimes，

admirabilis commented 3 years ago

My cursor is not restored even with atexit.register(bar.finish).

EDIT: but I can live with hide_cursor=False.