verilog-to-routing / vtr-verilog-to-routing

Verilog to Routing -- Open Source CAD Flow for FPGA Research
https://verilogtorouting.org
Other
1k stars 386 forks source link

Remove some out of date TO-DO and comments in rr_graph.cpp #1995

Open vaughnbetz opened 2 years ago

vaughnbetz commented 2 years ago

I think there are some out of date comments from the refactoring of the rrgraph apis in rr_graph.cpp (and perhaps related files).

E.g.:

rr_graph.cpp: /* TODO: The casting will be removed when RRGraphBuilder has the following APIs:

(seems to be done).

rr_graph2.cpp: https://github.com/verilog-to-routing/vtr-verilog-to-routing/blob/220fa98c059e45549b4ed0227d87f1048b6b0ea4/vpr/src/route/rr_graph2.cpp#L1128

These should be cleaned up.

tangxifan commented 2 years ago

@vaughnbetz Thanks for pointing this out. I will assign this to the team and create related pull requests.

tangxifan commented 2 years ago

@behzadmehmood-rs Can you arrange the team on cleaning up the code comments and create PRs? If you have anything unclear, just let me know. I will review your PR once it is available.

behzadmehmood-rs commented 2 years ago

@behzadmehmood-rs Can you arrange the team on cleaning up the code comments and create PRs? If you have anything unclear, just let me know. I will review your PR once it is available.

Sure, we will do that @tangxifan.