search

verilog-to-routing / vtr-verilog-to-routing

Verilog to Routing -- Open Source CAD Flow for FPGA Research
https://verilogtorouting.org
Other
979 stars 378 forks source link

[CI] Cleaned Up Artifacts and Resolved Deprecation #2597

Closed AlexandreSinger closed 2 weeks ago

AlexandreSinger commented 3 weeks ago

When artifacts were being saved for the regression tests, it was saving all of the benchmarks as blif files. This is incredibly wasteful (72 MB per regression test or around 720 MB per CI run). These tests will no longer save .blif files as artifacts anymore. If anyone needed these files they could generate them themselves or can add a condition to add the exact .blif files they may need.

The CI was also always generating artifacts (at least for the nightly tests) even when the run was cancelled. Made it so the artifacts are only saved if the run is not cancelled. This would mean an artifact is generated if the run succeeds or fails.

save-output was deprecated. Resolved. See: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

image
AlexandreSinger commented 3 weeks ago

@soheilshahrouz Are you ok with this change with when artifacts are saved? This change will make it so when a run in cancelled it will not save the artifacts, but it will save the artifacts if the run succeeds or fails. I anticipate there will be more cancelled runs in the future, so this will prevent saving artifacts when they are not needed.

AlexandreSinger commented 3 weeks ago

@vaughnbetz This has passed CI. I have verified that the artifacts are no longer being collected on cancellation and the overall size of the artifacts decreased from 1000 MBs per run to 250 MBs per run. 120 MBs is being taken up from vtr_reg_nightly_test1, so if we have issues in the future we can see what we need to be collecting for that test.

I have also verified that the deprecation warning is now gone.