ueqri
commented
2 weeks ago Expectations:
- The "Test" and "Container" CI workflows are skipped as expected, according to https://github.com/verilog-to-routing/vtr-verilog-to-routing/pull/2605/checks.
- The Read the Docs are also built successfully, https://vtr-verilog-to-routing--2605.org.readthedocs.build/en/2605/
Remaining Issues:
"Some checks haven’t completed yet": It appears to be the issue Alex mentioned in https://github.com/verilog-to-routing/vtr-verilog-to-routing/issues/2598#issuecomment-2155633380.
A potential issue you may run into is that there are required tests in our PR flow (sets of tests which must succeed in order for the code to be merged in). If the CI does not run for documentation changes, the PR may never be merged since it did not pass the required tests. I am not sure the best way to resolve this issue, but it should be resolved.
Moreover, here is the exact troubleshoot reference from GitHub.
If a workflow is skipped due to path filtering, branch filtering or a commit message, then checks associated with that workflow will remain in a "Pending" state. A pull request that requires those checks to be successful will be blocked from merging.
If, however, a job within a workflow is skipped due to a conditional, it will report its status as "Success". For more information, see "Using conditions to control job execution."
Potential Solutions:
- Solution 1: Maybe we can fix it by disabling the 'Require status checks to pass' in the Branch Protection Rule Settings.
- Solution 2: Instead of using path filtering on the CI trigger, we can use job conditions to prevent CI job execution for unnecessary tasks. However, this requires using a third-party
dorny/paths-filter@v3component as the first job step, rather than just relying on a GitHub CI primitive as we did before.
vaughnbetz
Close #2545.
Rewrote the existing Profiling VTR section, specifically the one using GNU
gproftool.Added another subsection to explain how to use the Linux
perftool to profile VPR and visualize its output.