search

veripool / verilog-mode

Verilog-Mode for Emacs with Indentation, Hightlighting and AUTOs. Master repository for pushing to GNU, verilog.com and veripool.org.
http://veripool.org/verilog-mode
GNU General Public License v3.0
247 stars 90 forks source link

Allows parameter declaration statements to be treated as like any other declaration #1683

Closed vinamarora8 closed 3 years ago

vinamarora8 commented 4 years ago

This completely solves fontification of parameter declarations.

As a side effect, indentation behavior is changed as well. Before this, parameter statements (w/o a declaration suffixes) were not being considered for indentation in verilog-pretty-declarations. I believe new behavior is 'correct', however it leads to failing indentation tests. So merging this would require us to edit tests_ok files to account for this behavior. How do we go about doing that? Just blindly replace them with newly generated ones?

wsnyder commented 4 years ago

Yes, replace the files. Easiest is to

HARNESS_UPDATE_GOLDEN=1 make test
wsnyder commented 4 years ago

( And after that, obviously review diffs)

vinamarora8 commented 3 years ago

All the tests_ok files have been updated. 2 tests/ files had to be changed. One of them had a typo, the other one is the one with the file-comment above.

I've gone through all the diffs, and to me all the changes seem reasonable.

wsnyder commented 3 years ago

Changing this spacing might be unpopular, but I agree it's more consistent, we'll see ;)

Thanks for your work on this - if there are other issues here you'd like to work on it would be very appreciated by all.