search

veripool / verilog-mode

Verilog-Mode for Emacs with Indentation, Hightlighting and AUTOs. Master repository for pushing to GNU, verilog.com and veripool.org.
http://veripool.org/verilog-mode
GNU General Public License v3.0
247 stars 90 forks source link

Refactor declaration regexps and some code cleaning #1786

Closed gmlarumbe closed 1 year ago

gmlarumbe commented 1 year ago

Hi,

This PR should not add any functional change.

First commit removes unused declaration regexps and does some refactoring to group all declaration regexp related code into one function. This should make functions like verilog-pretty-declarations and verilog-pretty-expr more easily maintainable.

Second commit removes some commented code on previous functions and fixes a typo on one of the variable names.

Since this is somehow a code cleaning PR I thought both commits could be squashed into a single one. What do you think @wsnyder ?

Thanks!

gmlarumbe commented 1 year ago

Thanks again for the review @wsnyder !

I will then rebase both commits onto master.