Author Name: Marek Rouchal
Original Redmine Issue: 115 from https://www.veripool.org
Original Date: 2009-07-27
Original Assignee: Wilson Snyder (@wsnyder)
Grrr, the Perl_newXS prototype is missing a const, but it's too late to
change the perl internals, so please try the below patch. You'll need
to "make clean" then start from scratch.
BTW if you have additional bugs, please use
http://www.veripool.org/projects/verilog-perl/issues
diff --git a/Preproc/xsubppfix b/Preproc/xsubppfix
index be13899..e13063f 100755
--- a/Preproc/xsubppfix
+++ b/Preproc/xsubppfix
@@ -13,6 +13,7 @@ foreach my $line (<STDIN>) {
1. "warning: deprecated conversion from string constant to âchar*â"
$line =~ s/^ *char\* file = __FILE__;/char* file = (char*)__FILE__;/;
$line =~ s/newXSproto\(\"/newXSproto((char*)\"/;
+ $line =~ s/(newXSproto.*), *\"/$1, (char*)\"/;
#
print "$line";
}
Mon Jul 27 07:52:37 2009 RT_System - Status changed from 'new' to 'open'
Thank you for the patch - I had to edit it a bit, and with the script
below the build and all tests pass OK.
Cheers,
Marek
#!/usr/bin/perl -w
#
1. Copyright 2008-2009 by Wilson Snyder. This program is free software;
1. you can redistribute it and/or modify it under the terms of either the GNU
1. Lesser General Public License Version 3 or the Perl Artistic License
Version 2.0.
#
######################################################################
1. DESCRIPTION: Edits xsubpp output to get around various issues.
foreach my $line (<STDIN>) {
1. Fix xsubpp 1.9508 and GCC 4.2.1 warning
1. "warning: deprecated conversion from string constant to
â<80><98>char*â<80><99>"
$line =~
s/^(\s*)(?:const\s*|)char\*\s*file\s*=\s*__FILE__;/${1}char* file =
(char*)__FILE__;/;
if($line =~ /newXSproto/) {
$line =~ s/([(,]\s*)"/$1(char*)"/g;
}
#
print "$line";
}
Thanks for your work on the fix.
I've committed this to git, and it will be in the next release; 3.213.
If you need it on CPAN immediately let me know.
Tue Jul 28 08:41:02 2009 WSNYDER - Status changed from 'open' to 'resolved'
Author Name: Marek Rouchal Original Redmine Issue: 115 from https://www.veripool.org Original Date: 2009-07-27 Original Assignee: Wilson Snyder (@wsnyder)
This bug was cloned from Perl-RT, rt48226.
Email addresses have have been truncated.
Mon Jul 27 04:06:30 2009 MAREKR - Ticket created
Mon Jul 27 07:52:36 2009 WSNYDER - Correspondence added
Mon Jul 27 07:52:37 2009 RT_System - Status changed from 'new' to 'open'
Tue Jul 28 07:54:29 2009 MAREKR - Correspondence added
Tue Jul 28 08:41:00 2009 WSNYDER - Correspondence added
Tue Jul 28 08:41:02 2009 WSNYDER - Status changed from 'open' to 'resolved'
Mon Sep 14 13:14:09 2009 WSNYDER - Correspondence added
Mon Sep 14 13:14:10 2009 RT_System - Status changed from 'resolved' to 'open'