search

verisign / storm-graphite

An Apache Storm IMetricsConsumer that forwards Storm's built-in metrics to a Graphite server for real-time graphing, visualization, and operational dashboards.
Other
75 stars 38 forks source link

add support for UDP graphite client #21

Closed Crim closed 9 years ago

KevinJMao commented 9 years ago

LGTM. Can you update README.md and CHANGELOG.md with your changes?

Crim commented 9 years ago

I updated the changelog and version in gradel to 2.4. I was unsure of the best place to note the configuration option in the README.md file however.

KevinJMao commented 9 years ago

Adding the optional field in the example storm.yaml snippet should be fine. Maybe something like

Reporting Metrics to Graphite
---
### Note: This is Storm's storm.yaml configuration file

# Controls the time interval between metric reports
topology.builtin.metrics.bucket.size.secs: 10
topology.metrics.consumer.register:
  - class: "com.verisign.storm.metrics.GraphiteMetricsConsumer"
    parallelism.hint: 1
    argument:
      metrics.reporter.name: "com.verisign.storm.metrics.reporters.graphite.GraphiteReporter"
      metrics.graphite.host: "graphite.example.com"
      metrics.graphite.port: "2003"
      metrics.graphite.prefix: "storm.test"
      metrics.graphite.min-connect-attempt-interval-secs: "5"
      # Optional arguments can also be supplied to enable UDP
      metrics.graphite.protocol: "udp"
Crim commented 9 years ago

Done! Let me know if there are any other tweaks you'd like to see. :)

KevinJMao commented 9 years ago

LGTM