search

veritrans / SNAP-Woocommerce

MIT License
19 stars 16 forks source link

add filter to customize rate convertion #34

Closed marulitua closed 4 years ago

marulitua commented 4 years ago

We need this filter to update currency rate on runtime. We keep modified this plugin every time a new version released so we create this pull request to help ourselves and hopefully many more.

rizdaprasetya commented 4 years ago

Thanks for the Pull Request, nice one 👍 Yes we are also planning to add WP filter/hook that can help some other developer who would like to use custom logic, etc.

We'll review this and probably include in the next version release. Thank you for contributing 😃

rizdaprasetya commented 4 years ago

Hi @marulitua thanks for the idea and feedback, we have implemented the filter, but to keep things consistent on our codebase we decided to use more descriptive name midtrans_to_idr_rate to make it easier for other dev to understand: https://github.com/veritrans/SNAP-Woocommerce/blob/e506a2f970afba74f6f1f7c2aaf775fbc3883b4a/abstract/abstract.midtrans-gateway.php#L54-L57 Please be aware of the new name, and update your custom code/filter to match the new name above, if you are planning to update to the next plugin version.

Since this changes is included on our ongoing revamp when this PR is made, we included on the revamp instead, and we'll close this PR. Thanks for the contribution!