veritrans / veritrans-php

PHP client library for Veritrans
93 stars 85 forks source link

Inconsisten requirement option for item_details parameter in VtWeb #37

Closed cod3beat closed 5 years ago

cod3beat commented 9 years ago

Base on the VtWeb.php file on line 15 - 21, it seems that when item_details parameter are provided, the quantity and price fields become mandatory for each of the items inside item_details.

This is different from the http://docs.veritrans.co.id/en/api/methods.html page, where it states that the quality and price fields are optional.

robeth commented 9 years ago

Hi @keripix, thank you for using veritrans-php.

In the new code base, line 15-21, that you've referred, have been moved to line 38 - 44 (VtWeb.php).

It turns out that our documentation is wrong. The code is right.

Thank you for reporting this issue. Our support team will update the documentation page :smile:

yocki-s commented 9 years ago

docs already update

dimasdanz commented 7 years ago

Sorry, but the doc is not updated. https://api-docs.midtrans.com/#item-details

yocki-s commented 7 years ago

hi @Dimasdanz

Thanks for your information.

As our documentation said, for now this is the specs:

fahrirusliyadi commented 6 years ago

In the doc, the item id of item_details is optional, but the sanitizer does not check its existence.