search

veritrans / veritrans-ruby

Ruby library for Veritrans payment gateway (Indonesia)
http://docs.veritrans.co.id/en/welcome/index.html
Apache License 2.0
44 stars 28 forks source link

Update create snap token endpoint #24

Closed hafizh-vt closed 7 years ago

hafizh-vt commented 7 years ago

before rebranding, we changed the endpoint. sorry we missed to update plugins. https://snap-docs.midtrans.com/#backend-integration

Paxa commented 7 years ago

Thank you for pull request BTW at the time I developed I hoped production URL will be on same domain, but now it's not So config.api_host.sub('//api.', '//app.') will not be == https://app.midtrans.com/snap/v1/transactions Do you think it will be better to set a different config variable for that? (may be config.snap_api_host)

Also could you please update example in https://github.com/veritrans/veritrans-ruby/blob/7369614b2819ff8d6335c3df965efa8dc4b14205/example/sinatra.rb#L51

hafizh-vt commented 7 years ago

I think it's okay to leave api_host with veritrans domain for now. Core API & Snap still support both domain, at least for a while.