Closed Ragnar-H closed 7 years ago
Ready
Static type checking of what we got. CI now lints and flow checks
Getting rid of type errors such as:
src/Components/CaseCard/index.js:30 30: subtitle={parliament_case.parliament_session.name} ^^^^^^^^^^^^^^^^^^ property `parliament_session`. Property not found in 30: subtitle={parliament_case.parliament_session.name} ^^^^^^^^^^^^^^^ object type src/Components/CaseCard/index.js:38 38: <span>Parliament: {parliament_case.parliament_session.parliament.name}</span> ^^^^^^^^^^^^^^^^^^ property `parliament_session`. Property not found in 38: <span>Parliament: {parliament_case.parliament_session.parliament.name}</span> ^^^^^^^^^^^^^^^ object type src/Components/CaseCard/index.js:41 41: <span>Parliament session: {parliament_case.parliament_session.name}</span> ^^^^^^^^^^^^^^^^^^ property `parliament_session`. Property not found in 41: <span>Parliament session: {parliament_case.parliament_session.name}</span> ^^^^^^^^^^^^^^^ object type src/types.js:28 28: created: date, ^^^^ identifier `date`. Could not resolve name src/utils/testFixtures.js:45 45: export const Parties: Array<PartyType> = [ ^^^^^^^^^ property `website`. Property not found in v 46: { 47: id: 2, 48: name: 'Vinsti Grænir', 49: }, ^ object literal src/utils/testFixtures.js:45 45: export const Parties: Array<PartyType> = [ ^^^^^^^^^ property `website`. Property not found in v 50: { 51: id: 1, 52: name: 'Framsókn', 53: }, ^ object literal
I really recommend reading through https://flow.org/en/docs/types/ before reviewing this PR
@AriHrannar you can review this commit-by-commit
Status
Ready
Description
Static type checking of what we got. CI now lints and flow checks
Example | Screenshots
Getting rid of type errors such as:
Todos