I noticed two things looking through the code which we may want to clean up:
There is a general catch(Exception e). Exceptions should generally be more specific (for example NumberFormatException rather than catching the superclass Exception, as was written in our style guide.
automaton validation was turned off: config.DO_VALIDATION = false;. Why was this necessary?
I noticed two things looking through the code which we may want to clean up:
catch(Exception e)
. Exceptions should generally be more specific (for exampleNumberFormatException
rather than catching the superclassException
, as was written in our style guide.config.DO_VALIDATION = false;
. Why was this necessary?