Closed LuanVietNguyen closed 9 years ago
The structure looks generally right. I wouldn't merge it with the main line until there's more implementation, though. For collaboration on experimental features I think you can add a remote repository that another person forked rather than going through the main line.
Some thoughts:
Ok, we'll commit to Luan's branch for now, hopefully will not cause issues with other things being developed.
Ok, I added some basic classification into discrete or not with some basic unit tests in Luan's branch.
Luan: we'll continue to add changes for your stuff in this branch, then we'll merge them. If Christian start's writing code for this, please get him to pull from your fork.
Sounds good. Closing this pull request (issue another one once the implementation is completed, as discussed).
It is just a startup class, Dr Johnson can look at it and decide whether he want to merge it, and then continue to work on it soon.