search

verivital / hyst

HyST: A Source Transformation and Translation Tool for Hybrid Automaton Models
http://verivital.com/hyst/
Other
15 stars 18 forks source link

fix SpaceEx set-aggregation parameter #60

Closed MaxGaukler closed 4 years ago

MaxGaukler commented 4 years ago

The setting set-aggregation= from the SpaceEx .cfg file was ignored and changed to set-aggregation=chull, which yields different results.

This is a regression from commit 1591f8393113efb2d29c31a1da63bcada525d151. @stanleybak Could you please have a look if this doesn't break the change you intended in that commit?

Test case for correct behavior:

$ java -jar /hyst/src/Hyst.jar -tool spaceex '' -i /hyst/examples/toy/toy.xml -o /tmp/toy.xml
$ cat /hyst/examples/toy/toy.cfg | grep set-aggregation
set-aggregation = "none"
$ cat /tmp/toy.cfg  | grep set-aggregation
set-aggregation = none
$ java -jar /hyst/src/Hyst.jar -tool spaceex '' -i /hyst/examples/vanderpol/vanderpol.xml -o /tmp/vanderpol.xml
$ cat /hyst/examples/vanderpol/vanderpol.xml | grep set-aggregation
$ cat /hyst/examples/vanderpol/vanderpol.cfg | grep set-aggregation
set-aggregation = chull
$ cat /tmp/vanderpol.cfg | grep set-aggregation
set-aggregation = chull
$ java -jar /hyst/src/Hyst.jar -tool spaceex '-aggregation foobar' -i /hyst/examples/vanderpol/vanderpol.xml -o /tmp/vanderpol.xml
$ cat /tmp/vanderpol.cfg | grep set-aggregation
set-aggregation = foobar

Before, set-aggregation=none in the input config was changed to set-aggregation=chull in the output config.