search

verizonconnect / ngx-form-generator

Generate Angular ReactiveForms from OpenAPI documents
MIT License
44 stars 13 forks source link

Update generator-lib.ts #6

Closed ayrshid99 closed 3 years ago

ayrshid99 commented 3 years ago

Use undefined as default value instead of null as htt-client serializes nulls and sends them in the http request which may cause problems in the back end while de-serializing the nulls

martinmcwhorter commented 3 years ago

Thank you for this PR. These are always appreciated.

I believe the issue here is hypothetical? Are you currently experiencing the issue you describe because the fields are defaulted to null rather than undefined?

Can you please provide a link to a repo where you can recreate the issue.

Otherwise, generally I wouldn't want to merge a PR that is not either obvious, or the issue is not reproducible.

ayrshid99 commented 3 years ago

Thank you for this PR. These are always appreciated.

I believe the issue here is hypothetical? Are you currently experiencing the issue you describe because the fields are defaulted to null rather than undefined?

Can you please provide a link to a repo where you can recreate the issue.

Otherwise, generally I wouldn't want to merge a PR that is not either obvious, or the issue is not reproducible.

sorry my bad the problem was somewhere else