search

verloop / twirpy

Twirp's python implementation
The Unlicense
99 stars 20 forks source link

Add wsgi support #8

Open ofpiyush opened 4 years ago

drish commented 3 years ago

hi @ofpiyush !

thanks for working this issue, just wanted to check in and see if there are still any plans on getting this merged ?

ofpiyush commented 3 years ago

Hi @drish

At the time, I had stopped because I needed to focus on something else.

When I came back with a fresh perspective, I couldn't find a compelling reason to support WSGI.

Right now, this issue is waiting for that compelling reason.

drish commented 3 years ago

hey @ofpiyush okay, thanks for the update here !

So I think for anybody using a WSGI framework, the option would be to use https://github.com/daroot/protoc-gen-twirp_python_srv, since twirpy only support ASGI frameworks ?

ofpiyush commented 3 years ago

Last when I'd talked to Dan, he mentioned that it's still Python2 and he's unlikely to spend effort on the project as he's moved on from the job.

There's a branch with untested wsgi code on this as well based off of Dan's work.

https://github.com/verloop/twirpy/pull/17

If you can provide a compelling case for WSGI, I'd add it.