search

vermaden / automount

Simple devd(8) based automounter for FreeBSD
66 stars 20 forks source link

Add an option to not automount ESP #39

Closed probonopd closed 2 years ago

probonopd commented 2 years ago

Now that internal drives are automouted it would be useful to have an option to not automount EFI System Partition (ESP).

The globally unique identifier (GUID) for the EFI system partition in the GUID Partition Table (GPT) scheme is C12A7328-F81F-11D2-BA4B-00A0C93EC93B.

vermaden commented 2 years ago

"I'm Afraid I Can't Do That, Dave." - to cite HAL.

The automount(8) is for automounting everything - it does not matter if its some EFI shit or your casual pendrive.

You can make fork of automount(8) into automount-hello(8) for example so you may tailor it to your needs - if that is needed.

vermaden commented 2 years ago

I though about it for some time and maybe adding such an option will not be that bad idea.

I will try to look into that - maybe that would prevent creating the automount(8) fork and maintaining two versions :)

probonopd commented 2 years ago

maybe that would prevent creating the automount(8) fork and maintaining two versions :)

Yes, lets avoid that under any circumstance!

probonopd commented 2 years ago

The same should go for Microsoft Reserved Partition (MSR) partitions which have the GUID Partition Table (GPT) label E3C9E316-0B5C-4DB8-817D-F92DF00215AE according to https://en.wikipedia.org/wiki/Microsoft_Reserved_Partition.

Reference: https://twitter.com/Sweordbora/status/1482830236706295811

Thanks @pmhausen for pointing this out.

vermaden commented 2 years ago

I am sorry it took so long ... especially now knowing how little amount of code changes were needed ...

Added support to ignore EFI and MSR partitions in automount(8).

Details: https://github.com/vermaden/automount/commit/1b69cda21f4e31855f23c8864c1cfc052226816f

Just add IGNORE_SYS_PARTS=YES to the /usr/local/etc/automount.conf file.

Regards :)

probonopd commented 2 years ago

Great! :+1: Thank you very much @vermaden