search

vermaseren / form

The FORM project for symbolic manipulation of very big expressions
GNU General Public License v3.0
1.01k stars 120 forks source link

Version 4.2.1? #263

Closed tueda closed 3 years ago

tueda commented 6 years ago

More than a half year has passed after the release of version 4.2.0. Maybe it would be good to start to consider a possible next version slowly.

Questions are:

  1. Do we need a bug-fix release 4.2.1? Or wait for 4.3?
  2. For 4.2.1, should more fixes and some small additions be included? Which ones?

The current changes are summarized in https://github.com/vermaseren/form/wiki/Recent-ChangeLog, if I don't miss anything. It includes annoying gzip bugs and polynomial GCD bugs.

Ubuntu 18.04 LTS (Bionic Beaver) will appear on 26 April 2018 (and will be supported until April 2023), may be shipped with the FORM 4.2 (Sep 14 2017) anyway: https://packages.ubuntu.com/bionic/form. (They dropped .0 of 4.2.0 from form -v.)

jodavies commented 6 years ago

If a version 4.2.1 is released, it could be useful to provide a SUBSUBVERSION_ preprocessor variable. One could use this to enforce a certain level of bug-fixing in a script.

alexmyczko commented 5 years ago

Early 2019, Debian will ship a new stable release, maybe it'd be great to have a new release short before of that for them to deliver?

benruijl commented 5 years ago

That sounds like a good idea!

tueda commented 5 years ago

I think even the current one (+ possibly some bugfixes + extra) would be OK for 4.2.1 or 4.3.0, once Jos is satisfied with the version. Here is the list of changes from 4.2: https://github.com/vermaseren/form/wiki/Recent-ChangeLog.

vermaseren commented 5 years ago

Would a date in early Januari be fine, or is there more of a hurry. Potentially we might get in the namespaces in that case. Some of the outstanding bugfixes are rather hard, but I can try.

Version 4.3.0 would be fine. Specially if we get the namespaces.

Jos

On 8 Nov 2018, at 20:03, Takahiro Ueda notifications@github.com wrote:

I think even the current one (+ possibly some bugfixes + extra) would be OK for 4.2.1 or 4.3.0, once Jos is satisfied with the version. Here is the changes from 4.2: https://github.com/vermaseren/form/wiki/Recent-ChangeLog https://github.com/vermaseren/form/wiki/Recent-ChangeLog.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vermaseren/form/issues/263#issuecomment-436956960, or mute the thread https://github.com/notifications/unsubscribe-auth/AFLxElYYvKTc1Gb_gNx7MUsjZLcO1ol9ks5utA-RgaJpZM4R_zm7.

alexmyczko commented 5 years ago

Summary from https://release.debian.org/buster/freeze_policy.html 2019-01-12 - Transition freeze 2019-02-12 - Soft-freeze 2019-03-12 - Full-freeze

I'd go for earlier so some people can already test it, it takes 5 days from unstable to wander into testing (which will become stable after the freeze)

alexmyczko commented 5 years ago

any news here? happy new year! GREAT!

so looking forward for 1) the new release 2) examples 3) benchmarks with gcc, tcc (interpreted, built-at-run-time), clang (maybe icc) 4) tests with/without zram

benruijl commented 5 years ago

Form 4.2.1 has been released!

tueda commented 5 years ago

You failed. The build script can't recognize the version because it must be v4.2.1; I think the configure script still says FORM 4.2.0 in your build (you need to rerun autoreconf -ifv). See: https://github.com/vermaseren/form/blob/eaf85a757a9f7bb69c9bdc4bf6ec07e48f5769ac/scripts/git-version-gen.sh#L99-L103 Another problem was the Github token to deploy files to the release page was somehow expired(?) I don't remember whose token was used, but for now I put my token. Can you put the correct tag and remake the release?

Maybe copyrights should be updated (to 2019), but this is a minor release and we may skip it...

tueda commented 5 years ago

By the way, why do you spell Form instead of FORM while you spell reFORM for your software :-)

tueda commented 5 years ago

Another thing: are we happy to have "undocumented" changes documented in the release notes?

benruijl commented 5 years ago

Ah yes, you are totally right. I should push a version bump and then move the tag. I can do that tomorrow. For now, I've tagged the release as a pre-release.

Maybe we can move the undocumented change out of the release notes and just keep it in the global changelog that you made.

tueda commented 5 years ago

Thanks! Now the tarball gives

FORM 4.2.1 (Nov 21 2018, v4.2.1) 64-bits         Run: Mon Feb  4 21:45:30 2019

Ben, can you also update the AUR package? I will update the Homebrew one and the installation page.

tueda commented 5 years ago

For undocumented changes, yes, we could just keep them in the change log, and they would be officially not supported in 4.2.1. But for the setup parameters, now the manual is wrong...

benruijl commented 5 years ago

Yes that is unfortunate... I don't know what the best course of action is. In the future we should document in the same commit.

tueda commented 5 years ago

Because different memory sizes are assigned for sequential and threaded versions in https://github.com/vermaseren/form/commit/689b72dd76f3da7b52ee0fd9bd00d325c1cc0c9b#diff-0a9454c43ec7e8c79439a330681bf16d, perhaps the table for default settings in the setup section needs 4 columns? Or the whole layout of the table should be reconsidered? ....Hopefully will be fixed in v4.2.1.1 or something like that.

alexmyczko commented 5 years ago

where's the new tarball? checkout master and call it 4.2.1.1?

tueda commented 5 years ago

The tarball of v4.2.1 is in the Github Release page: form-4.2.1.tar.gz. A possible next version v4.2.1.1 (or v4.3.0) is still a science fiction.

alexmyczko commented 5 years ago

I'm sorry, this is rocket science. I download the url and the doc doesn't build :(

tueda commented 5 years ago

@alexmyczko Could you show the log of ./configure and make pdf, for example, by putting the log in a Gist?

alexmyczko commented 5 years ago

I don't know what gist is, nor do i have it. But I have this log file: http://phd-sid.ethz.ch/debian/form/form_4.2.1-1_amd64.build

tueda commented 5 years ago

Probably you have a file form/doc/doxygen/pdflatex/comtool_8c.tex generated by Doxygen. Can you paste the first 100 lines? The error occurred around l.73.

tueda commented 5 years ago

Another option: if you need to make only doc/manual/manual.pdf while your Doxygen/PDFLaTeX is buggy, you can skip to make doc/doxygen/doxygen.pdf: Just use make -C doc/manual pdf.

alexmyczko commented 5 years ago

can you browse the url it should be all there see debian/rules i inly want the pdf for the 100 lines should also be there...

tueda commented 5 years ago

OK, I can see the comtool_8c.tex, but I don't see anything clearly wrong around l.73....

tueda commented 5 years ago

As far as I understand, you only install doc/manual/manual.pdf (in form-docs.docs), so

override_dh_auto_build:
    dh_auto_build
    $(MAKE) -C doc/manual pdf

would be enough, I guess.