search

vermaseren / form

The FORM project for symbolic manipulation of very big expressions
GNU General Public License v3.0
1.01k stars 120 forks source link

Change behaviour of "On fewerstatistics 0" #285

Closed jodavies closed 4 years ago

jodavies commented 6 years ago

Never print statistics for small buffer sort, if ShortStatsMax is 0

Often I want statistics enabled, but only for the final sort (to see the number of terms in output). For large calculations, one can get many thousands of lines for small-buffer sorts, even with fewerstats set as large as possible.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.05%) to 48.542% when pulling 6ed16adf8f416579bc983d50580e0b5e2452bb60 on jodavies:fewerstatistics into e8c97981ac4f7ac6d80006a2dff562c951f8c7ab on vermaseren:master.

jodavies commented 4 years ago

Does anyone have any opinions on this? It's a trivial change, but I am re-applying it every time I pull new commits from the repo...

tueda commented 4 years ago

I think this is OK to merge; hopefully, no one relies on the old behaviour of fewerstatistics 0 (for the meaning of fewerstatistics 1)...

tueda commented 4 years ago

@vermaseren Jos, is it OK to merge? This is backwards-incompatible, in a strict sense. Maybe you know some background of the decision of the behaviour of fewerstatistics 0.

vermaseren commented 4 years ago

I guess it is OK. Internally it affects only the printing of the statistics in the WriteStats routine as far as I know. It may change some outputs in the sense that the number of statistics printouts changes. This again could potentially affect scripts that process outputs. But the value 1 is still available and it would probably be rather easy to spot this and also very easy to repair, using grep. Just do not forget to change the manual.

Jos

On 17 Jul 2020, at 12:35, Takahiro Ueda notifications@github.com wrote:

@vermaseren https://github.com/vermaseren Jos, is it OK to merge? This is backwards-incompatible, in a strict sense. Maybe you know some background of the decision of the behaviour of fewerstatistics 0.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vermaseren/form/pull/285#issuecomment-660028895, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJPCEXTF7K3TOP6C3AEMH3R4ASOJANCNFSM4FF4B6LQ.

tueda commented 4 years ago

The document change is also included in this pull request, so I will merge it...

jodavies commented 4 months ago

It looks like the change in sort.c due to this was reverted in the FORM5 code merge (but the manual is intact).

tueda commented 4 months ago

OK, I will re-apply it.