search

vermaseren / form

The FORM project for symbolic manipulation of very big expressions
GNU General Public License v3.0
1.15k stars 136 forks source link

Add test for PR #500 #503

Closed jodavies closed 5 months ago

jodavies commented 5 months ago

Also overlooked in PR: align the warning messages from the two cases.

coveralls commented 5 months ago

Coverage Status

coverage: 48.711% (+0.2%) from 48.49% when pulling 0f0509b1a3a36cb08ddd28e9c495f882bcc99409 on jodavies:test-500 into 1fecb400d296a331742bcbeaa2a20df2a728de2d on vermaseren:master.

tueda commented 5 months ago

To confirm, did you choose "expr" instead of "expression" just because of brevity? Or because the warning? method didn't work with long lines where newline characters are inserted? If it is the latter case, #504 provides the solution.

jodavies commented 5 months ago

For brevity. I thought it better if it is more likely to fit on one line. Of course if you change the width or have sufficiently long expression names there will be linebreaks anyway.

tueda commented 5 months ago

OK, then I will merge it (and then #504; there should be no more oversights in warnings? etc., I hope).