search

vermaseren / form

The FORM project for symbolic manipulation of very big expressions
GNU General Public License v3.0
985 stars 118 forks source link

Pass the master struct in MasterMerge #520

Closed jodavies closed 1 month ago

jodavies commented 1 month ago

CompareTerms needs to be able to change flags in the caller's sort struct (PolyWise, for eg). Using the BHEAD macro here does not pass the right struct.

This leads to polyratfun merging bugs when using tform -w2 (which disables the sortbots).

I think changing the argument of MergeWithFloat won't do anything, but just in case some functionality is added there in the future...

coveralls commented 1 month ago

Coverage Status

coverage: 48.767% (-0.02%) from 48.788% when pulling 44c926605101644ffeb4584354bf5f71171c480d on jodavies:issue-468-extra into 74735f57a7351e5c790648f2332d06c164d701d0 on vermaseren:master.

tueda commented 1 month ago

It works, so I will merge it. Thanks!