search

vermaseren / form

The FORM project for symbolic manipulation of very big expressions
GNU General Public License v3.0
1.15k stars 136 forks source link

test(check.rb): add #extra_args instruction #521

Open tueda opened 4 months ago

tueda commented 4 months ago

This is probably the simplest approach to resolve the issue (testing tform -w2) discussed in (https://github.com/vermaseren/form/pull/520#issue-2304774289).

This patch adds a new special instruction #extra_args that can be used to add extra command-line arguments to be passed to FORM. For example

#extra_args -w2

leads to run tform -w4 -w2 1.frm for testing TFORM.

Instead of adding #extra_args, other options would be:

  1. Run all TFORM tests with -w2 and then with -w4.
  2. Add 
    #threads 2,4

    to run TFORM tests with -w2 and then with -w4.

jodavies commented 4 months ago

I would say it is probably best to run the entire set of tests with both w2 and w4. I am not sure on the limits of github's runners. The valgrind tests are taking the majority of the time at the moment (and those should probably be run with both w2 and w4 as well, since different code runs...). #520 manifests even for very trivial input. Maybe there is even something in the current set of tests that doesn't work with w2...

coveralls commented 4 months ago

Coverage Status

coverage: 48.768% (+0.004%) from 48.764% when pulling c34be2dcee0ad8c58800016a60740b6f9fc1e48a on tueda:test-extra_args into 87b4bcf29ed21223c3ee9c979497086dc2e3fb73 on vermaseren:master.

tueda commented 4 months ago

You are right. Adding -w2 actually caused many test failures... (I'll create a PR).