Closed tueda closed 1 month ago
Contrary to my expectations, for some reason all tests passed for this PR, though some of them failed for my fork. It's strange...
Some of those seem not unexpected if you didn't have #520 in your fork. Things seem OK now, also in your fork? What changed there?
You are right. After correctly rebasing with the upstream branch, it now works.
This patch adds test jobs with
-w2
to CI. See also https://github.com/vermaseren/form/pull/520#issue-2304774289 and another solution to test-w2
by adding#extra_args
https://github.com/vermaseren/form/pull/521.Currently, it gives 5 test failures:
Issue178 (fixes.frm:1651)
Issue313 (fixes.frm:2294)
Issue336_1 (fixes.frm:2355)
Issue336_2 (fixes.frm:2417)
Issue468 (fixes.frm:2684)
Moreover, Forcer doesn't work with
-w2
.Question: is it OK to merge it? Or, do we want to fix these failures before the merge?