vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub
GNU General Public License v3.0
579 stars 63 forks source link

Better highlighting Unread Notifications in magit-dashboard #151

Closed jgkamat closed 7 years ago

jgkamat commented 7 years ago

Continuing from #150

The 'normal' github notification system only shows unread notifications by default (unless you ask for them).

Here's a screenshot of the dashboard (which I think is the full dashboard now)

2017-10-22-132649_946x943_scrot

This is pretty unusable, since I've already seen all the notifications on the screen, and the notifications go down for a long while. A easy improvement for UX (I think) is collapsing the headers by default:

2017-10-22-131913_536x512_scrot.

However, this is still pretty painful (trying to find unread notifications) After scrolling down a long while, I came up with some of my unreads:

2017-10-22-133004_974x881_scrot

Another easy fix for this is to sort by newest first. I don't particularly like this because it encourages you to leave notifications un-attended for a while, but it is an easy fix.

A better fix (IMO) would be:

OR:

I like the first option more, since it would make opening it faster.

What are your thoughts on the issue? I'm not too familiar with the github API, so I'm not sure if getting only unread notifications is possible.

vermiculus commented 7 years ago

Only getting unread notifications is certainly possible and I can easily make that the behavior. What surprises me is the sheer number of notifications you have – I can never get more than 15 or so (read or unread) to show up, so I never experiences this usability issue.

Aside, only unread notifications should be expanded by default. Can you kill the buffer and reopen the dashboard? Are they all still expanded? That shouldn't be the case.

jgkamat commented 7 years ago

What surprises me is the sheer number of notifications you have – I can never get more than 15 or so

I'm not sure what consitutes as an 'unread' notification by the github API. I have had a lot more unread notifications in the past, maybe there's some sort of time cutoff. I watch a lot of repos :P

Aside, only unread notifications should be expanded by default. Can you kill the buffer and reopen the dashboard? Are they all still expanded? That shouldn't be the case.

They are definetly still expanded by default when running magithub-dashboard for me, is there any debug information I could provide that would help with that? :)

stardiviner commented 7 years ago

Why my command magithub-dashboard is not available after upgrade package magithub?

jgkamat commented 7 years ago

@stardiviner try (require 'magithub-dash).

Maybe an autoload on the function could be added to make it easier

stardiviner commented 7 years ago

@vermiculus Can you add autoload cookie ahead of function?

vermiculus commented 7 years ago

@stardiviner it's already there

jgkamat commented 7 years ago

magithub now hides read notifications by default, so I'm closing this. Feel free to reopen if this is still being worked on :)