vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub
GNU General Public License v3.0
579 stars 63 forks source link

Can't visit an issue #170

Closed jwiegley closed 6 years ago

jwiegley commented 6 years ago

I update magit, ghub, ghub+ and magithub today. This is my first time trying magithub. When I press RET on an issue, I see this:

Debugger entered--Lisp error: (error "Format specifier doesn’t match argument type")
  format("Getting issue %s#%d..." "/" nil)
  magithub-issue(((owner (login)) (name)) nil)
  magithub-issue-view--buffer-name(magithub-issue-view-mode nil)
  magit-generate-new-buffer(magithub-issue-view-mode nil)
  magit-mode-get-buffer(magithub-issue-view-mode t nil nil)
  magit-mode-setup-internal(magithub-issue-view-mode (((url . "https://api.github.com/repos/jwiegley/dot-emacs/issues/13") (repository_url . "https://api.github.com/repos/jwiegley/dot-emacs") (labels_url . "https://api.github.com/repos/jwiegley/dot-emacs/issues/13/labels{/name}") (comments_url . "https://api.github.com/repos/jwiegley/dot-emacs/issues/13/comments") (events_url . "https://api.github.com/repos/jwiegley/dot-emacs/issues/13/events") (html_url . "https://github.com/jwiegley/dot-emacs/issues/13") (id . 211944484) (number . 13) (title . "No url found for submodule path 'lib/emacs-request/doc/eldomain' in .gitmodules") (user (login . "twlz0ne") (id . 2653486) (avatar_url . "https://avatars3.githubusercontent.com/u/2653486?v=4") (gravatar_id . "") (url . "https://api.github.com/users/twlz0ne") (html_url . "https://github.com/twlz0ne") (followers_url . "https://api.github.com/users/twlz0ne/followers") (following_url . "https://api.github.com/users/twlz0ne/following{/other_user}") (gists_url . "https://api.github.com/users/twlz0ne/gists{/gist_id}") (starred_url . "https://api.github.com/users/twlz0ne/starred{/owner}{/repo}") (subscriptions_url . "https://api.github.com/users/twlz0ne/subscriptions") (organizations_url . "https://api.github.com/users/twlz0ne/orgs") (repos_url . "https://api.github.com/users/twlz0ne/repos") (events_url . "https://api.github.com/users/twlz0ne/events{/privacy}") (received_events_url . "https://api.github.com/users/twlz0ne/received_events") (type . "User") (site_admin)) (labels) (state . "open") (locked) (assignee) (assignees) (milestone) (comments . 1) (created_at . "2017-03-05T10:38:33Z") (updated_at . "2017-11-24T05:33:04Z") (closed_at) (author_association . "NONE") (body . "```sh\015\n└⋊> git clone --recursive https://github.com/jwiegley/dot-emacs emacs.d-jwiegley\015\nCloning into 'emacs.d-jwiegley'...\015\nremote: Counting objects: 21727, done.\015\nremote: Compressing objects: 100% (3/3), done.\015\nReceiving objects: 100% (21727/21727), 78.69 MiB | 37.00 KiB/s, done.\015\nremote: Total 21727 (delta 0), reused 0 (delta 0), pack-reused 21724\015\nResolving deltas: 100% (8635/8635), done.\015\nChecking out files: 100% (2711/2711), done.\015\nfatal: No url found for submodule path 'lib/emacs-request/doc/eldomain' in .gitmodules\015\n```"))) t)
  magithub-issue-view(((url . "https://api.github.com/repos/jwiegley/dot-emacs/issues/13") (repository_url . "https://api.github.com/repos/jwiegley/dot-emacs") (labels_url . "https://api.github.com/repos/jwiegley/dot-emacs/issues/13/labels{/name}") (comments_url . "https://api.github.com/repos/jwiegley/dot-emacs/issues/13/comments") (events_url . "https://api.github.com/repos/jwiegley/dot-emacs/issues/13/events") (html_url . "https://github.com/jwiegley/dot-emacs/issues/13") (id . 211944484) (number . 13) (title . "No url found for submodule path 'lib/emacs-request/doc/eldomain' in .gitmodules") (user (login . "twlz0ne") (id . 2653486) (avatar_url . "https://avatars3.githubusercontent.com/u/2653486?v=4") (gravatar_id . "") (url . "https://api.github.com/users/twlz0ne") (html_url . "https://github.com/twlz0ne") (followers_url . "https://api.github.com/users/twlz0ne/followers") (following_url . "https://api.github.com/users/twlz0ne/following{/other_user}") (gists_url . "https://api.github.com/users/twlz0ne/gists{/gist_id}") (starred_url . "https://api.github.com/users/twlz0ne/starred{/owner}{/repo}") (subscriptions_url . "https://api.github.com/users/twlz0ne/subscriptions") (organizations_url . "https://api.github.com/users/twlz0ne/orgs") (repos_url . "https://api.github.com/users/twlz0ne/repos") (events_url . "https://api.github.com/users/twlz0ne/events{/privacy}") (received_events_url . "https://api.github.com/users/twlz0ne/received_events") (type . "User") (site_admin)) (labels) (state . "open") (locked) (assignee) (assignees) (milestone) (comments . 1) (created_at . "2017-03-05T10:38:33Z") (updated_at . "2017-11-24T05:33:04Z") (closed_at) (author_association . "NONE") (body . "```sh\015\n└⋊> git clone --recursive https://github.com/jwiegley/dot-emacs emacs.d-jwiegley\015\nCloning into 'emacs.d-jwiegley'...\015\nremote: Counting objects: 21727, done.\015\nremote: Compressing objects: 100% (3/3), done.\015\nReceiving objects: 100% (21727/21727), 78.69 MiB | 37.00 KiB/s, done.\015\nremote: Total 21727 (delta 0), reused 0 (delta 0), pack-reused 21724\015\nResolving deltas: 100% (8635/8635), done.\015\nChecking out files: 100% (2711/2711), done.\015\nfatal: No url found for submodule path 'lib/emacs-request/doc/eldomain' in .gitmodules\015\n```")))
  magithub-issue-visit(((url . "https://api.github.com/repos/jwiegley/dot-emacs/issues/13") (repository_url . "https://api.github.com/repos/jwiegley/dot-emacs") (labels_url . "https://api.github.com/repos/jwiegley/dot-emacs/issues/13/labels{/name}") (comments_url . "https://api.github.com/repos/jwiegley/dot-emacs/issues/13/comments") (events_url . "https://api.github.com/repos/jwiegley/dot-emacs/issues/13/events") (html_url . "https://github.com/jwiegley/dot-emacs/issues/13") (id . 211944484) (number . 13) (title . "No url found for submodule path 'lib/emacs-request/doc/eldomain' in .gitmodules") (user (login . "twlz0ne") (id . 2653486) (avatar_url . "https://avatars3.githubusercontent.com/u/2653486?v=4") (gravatar_id . "") (url . "https://api.github.com/users/twlz0ne") (html_url . "https://github.com/twlz0ne") (followers_url . "https://api.github.com/users/twlz0ne/followers") (following_url . "https://api.github.com/users/twlz0ne/following{/other_user}") (gists_url . "https://api.github.com/users/twlz0ne/gists{/gist_id}") (starred_url . "https://api.github.com/users/twlz0ne/starred{/owner}{/repo}") (subscriptions_url . "https://api.github.com/users/twlz0ne/subscriptions") (organizations_url . "https://api.github.com/users/twlz0ne/orgs") (repos_url . "https://api.github.com/users/twlz0ne/repos") (events_url . "https://api.github.com/users/twlz0ne/events{/privacy}") (received_events_url . "https://api.github.com/users/twlz0ne/received_events") (type . "User") (site_admin)) (labels) (state . "open") (locked) (assignee) (assignees) (milestone) (comments . 1) (created_at . "2017-03-05T10:38:33Z") (updated_at . "2017-11-24T05:33:04Z") (closed_at) (author_association . "NONE") (body . "```sh\015\n└⋊> git clone --recursive https://github.com/jwiegley/dot-emacs emacs.d-jwiegley\015\nCloning into 'emacs.d-jwiegley'...\015\nremote: Counting objects: 21727, done.\015\nremote: Compressing objects: 100% (3/3), done.\015\nReceiving objects: 100% (21727/21727), 78.69 MiB | 37.00 KiB/s, done.\015\nremote: Total 21727 (delta 0), reused 0 (delta 0), pack-reused 21724\015\nResolving deltas: 100% (8635/8635), done.\015\nChecking out files: 100% (2711/2711), done.\015\nfatal: No url found for submodule path 'lib/emacs-request/doc/eldomain' in .gitmodules\015\n```")))
  funcall-interactively(magithub-issue-visit ((url . "https://api.github.com/repos/jwiegley/dot-emacs/issues/13") (repository_url . "https://api.github.com/repos/jwiegley/dot-emacs") (labels_url . "https://api.github.com/repos/jwiegley/dot-emacs/issues/13/labels{/name}") (comments_url . "https://api.github.com/repos/jwiegley/dot-emacs/issues/13/comments") (events_url . "https://api.github.com/repos/jwiegley/dot-emacs/issues/13/events") (html_url . "https://github.com/jwiegley/dot-emacs/issues/13") (id . 211944484) (number . 13) (title . "No url found for submodule path 'lib/emacs-request/doc/eldomain' in .gitmodules") (user (login . "twlz0ne") (id . 2653486) (avatar_url . "https://avatars3.githubusercontent.com/u/2653486?v=4") (gravatar_id . "") (url . "https://api.github.com/users/twlz0ne") (html_url . "https://github.com/twlz0ne") (followers_url . "https://api.github.com/users/twlz0ne/followers") (following_url . "https://api.github.com/users/twlz0ne/following{/other_user}") (gists_url . "https://api.github.com/users/twlz0ne/gists{/gist_id}") (starred_url . "https://api.github.com/users/twlz0ne/starred{/owner}{/repo}") (subscriptions_url . "https://api.github.com/users/twlz0ne/subscriptions") (organizations_url . "https://api.github.com/users/twlz0ne/orgs") (repos_url . "https://api.github.com/users/twlz0ne/repos") (events_url . "https://api.github.com/users/twlz0ne/events{/privacy}") (received_events_url . "https://api.github.com/users/twlz0ne/received_events") (type . "User") (site_admin)) (labels) (state . "open") (locked) (assignee) (assignees) (milestone) (comments . 1) (created_at . "2017-03-05T10:38:33Z") (updated_at . "2017-11-24T05:33:04Z") (closed_at) (author_association . "NONE") (body . "```sh\015\n└⋊> git clone --recursive https://github.com/jwiegley/dot-emacs emacs.d-jwiegley\015\nCloning into 'emacs.d-jwiegley'...\015\nremote: Counting objects: 21727, done.\015\nremote: Compressing objects: 100% (3/3), done.\015\nReceiving objects: 100% (21727/21727), 78.69 MiB | 37.00 KiB/s, done.\015\nremote: Total 21727 (delta 0), reused 0 (delta 0), pack-reused 21724\015\nResolving deltas: 100% (8635/8635), done.\015\nChecking out files: 100% (2711/2711), done.\015\nfatal: No url found for submodule path 'lib/emacs-request/doc/eldomain' in .gitmodules\015\n```")))
  call-interactively(magithub-issue-visit nil nil)
  command-execute(magithub-issue-visit)
vermiculus commented 6 years ago

This is probably caused by #171; the buffer lock value is nil. I'll see if I can provide a defadvice patch or something on the interim until the next release of magit.

vermiculus commented 6 years ago

Is this still an issue for you after addressing #171?

jwiegley commented 6 years ago

I'm waiting on the next release of magit to test. Until then, I'll assume this is fixed since others are not running into it.

vermiculus commented 6 years ago

Oh, gotcha; I'd assumed you'd switched to HEAD after your earlier comment 👍