search

vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub
GNU General Public License v3.0
579 stars 63 forks source link

When reporting an issue I get an error in `magithub-edit-delete-draft` #248

Closed hexmode closed 6 years ago

hexmode commented 6 years ago

emacs-version: "27.0.50"

The error indicates buffer-file-name is not defined.

Backtrace coming shortly, I hope.

vermiculus commented 6 years ago

As in buffer-file-name is nil or it truly is an undefined symbol?

hexmode commented 6 years ago

Debugger entered--Lisp error: (wrong-type-argument stringp nil) file-exists-p(nil) (if (file-exists-p buffer-file-name) (progn (delete-file buffer-file-name magit-delete-by-moving-to-trash))) magithub-edit-delete-draft() magithub-issue-post-submit() funcall-interactively(magithub-issue-post-submit) call-interactively(magithub-issue-post-submit) magithub-edit--done(magithub-issue-post-submit) magithub-edit-submit() funcall-interactively(magithub-edit-submit) call-interactively(magithub-edit-submit nil nil) command-execute(magithub-edit-submit)

vermiculus commented 6 years ago

Ah, I'd thought I'd tested that case. Thanks for the catch!

vermiculus commented 6 years ago

Ah, I'd been testing magithub-edit-cancel.