Closed iravid closed 6 years ago
I just started using Magithub and it's awesome, so thought I'd pick something off the issues list and solve it :-)
Can't wait to try it out, thanks!!
Sure :-) I had to context switch so I couldn’t try it out myself yet, but hopefully tonight :)
Whoops, sorry, I misread the code and this isn't doing the right thing yet.
Ok, should be good now. I'm not sure it's the cleanest way of doing this as https://stackoverflow.com/a/605931/2535374 says we should be using the (interactive "r")
form to integrate the start/end points into the function arguments, but it works :-)
It's not working for me ☹ use-region-p
is returning nil because region-active-p
is nil.
Unless I'm doing something incorrectly:
C-SPC
to start the selection (i.e., place mark).r
to call magithub-comment-reply
.It's not working for me ☹
use-region-p
is returning nil becauseregion-active-p
is nil.Unless I'm doing something incorrectly:
- Place point at start of region.
C-SPC
to start the selection (i.e., place mark).- Move point to the end of my region.
- Use
r
to callmagithub-comment-reply
.
Hmm, strange. It's not working here too, but use-region-p
and region-active-p
are evaluating to t
when I test them with the region active.
However, I'm using Spacemacs and activating the region using v
(e.g. Visual Line in evil). Maybe that has something to do with it?
I do remember getting it working at some point ;) Let me dig into this some more.
Ahh, it's probably because I moved the call to use-region-p
into the with-temp-buffer
form.
Ok, give this another try :-)
Hey @vermiculus, had a chance to give this another try?
Sorry it's taken me a little while; work's been a little crazy 😄 I'm looking now.
Things are looking good! Posting a link to test that.
Thanks!
Resolves #244