Closed purcell closed 6 years ago
This is awesome! Thanks for doing this :smile:
Note to myself that this will also close #23.
Okay, added that last bit - please check it over. :-)
Looks like there's just a single teeny build bug (just need a declare-function
for the compiler, methinks).
Could you add documentation for the completion
feature in that variable? :-)
I'll take a look now.
Thanks!
Woot, thanks for shepherding this through. I'm happier with this result than if I'd published a separate add-on package. Keep up the good work!
It's a great addition 😄
This allows completion of
#123
issue numbers etc. with vanilla Emacs'completion-at-point
mechanism, with extended completion attributes so thatcompany
's completion-at-point backend can show further information about candidates.I was going to publish this as a separate little package, but it arguably belongs in
magithub
directly. In its current form, there is no change in default behaviour, i.e. completion is never auto-enabled: this is the more conservative choice, but perhaps this functionality warrants loading via themagithub-features
mechanism.Thoughts for future enhancement:
@user
patterns from known user names (relates to discussion of caching users in #262).