vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub
GNU General Public License v3.0
579 stars 63 forks source link

Add support for completion of issue numbers in relevant buffers #263

Closed purcell closed 6 years ago

purcell commented 6 years ago

This allows completion of #123 issue numbers etc. with vanilla Emacs' completion-at-point mechanism, with extended completion attributes so that company's completion-at-point backend can show further information about candidates.

I was going to publish this as a separate little package, but it arguably belongs in magithub directly. In its current form, there is no change in default behaviour, i.e. completion is never auto-enabled: this is the more conservative choice, but perhaps this functionality warrants loading via the magithub-features mechanism.

Thoughts for future enhancement:

vermiculus commented 6 years ago

This is awesome! Thanks for doing this :smile:

vermiculus commented 6 years ago

Note to myself that this will also close #23.

purcell commented 6 years ago

Okay, added that last bit - please check it over. :-)

vermiculus commented 6 years ago

Looks like there's just a single teeny build bug (just need a declare-function for the compiler, methinks).

Could you add documentation for the completion feature in that variable? :-)

purcell commented 6 years ago

I'll take a look now.

vermiculus commented 6 years ago

Thanks!

purcell commented 6 years ago

Woot, thanks for shepherding this through. I'm happier with this result than if I'd published a separate add-on package. Keep up the good work!

vermiculus commented 6 years ago

It's a great addition 😄