vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub
GNU General Public License v3.0
579 stars 63 forks source link

Allow magithub-edit buffers to invoke popups upon submission #267

Open vermiculus opened 6 years ago

vermiculus commented 6 years ago

From #264.

Right now, this is a little complicated. Once a popup is invoked, control returns back to the top-level while the popup waits for user input. As this happens (i.e., immediately when magit-invoke-popup returns), magithub-edit-submit closes the buffer and tries to get every buffer back to the way it was.

We could work around this limitation by using a special return symbol in the callback to avoid all this. This will be...complicated.

@tarsius -- re transient.el, I don't expect you'll be changing this behavior from magit-popup into transient.el, but I'd thought I'd ask.

tarsius commented 6 years ago

That's right.

vermiculus commented 6 years ago

Thanks :-)