search

vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub
GNU General Public License v3.0
579 stars 63 forks source link

create non-existing directory before really run process #282

Closed stardiviner closed 6 years ago

vermiculus commented 6 years ago

Thanks! I wonder though if we should be waiting to create the directory until after the confirmations after all -- if the user quits out (C-g), we don't want an empty directory just hanging about.

I'll think about this some more today. For now, I'm going to amend your commit to correct the release notes, so be sure to pull down the latest changes from your branch if you want to make further changes :smile:

stardiviner commented 6 years ago

Thanks for quick response. You're great programmer!

vermiculus commented 6 years ago

Merged, but mostly be accident. In the future, please don't name your fork branches 'master' 😄

vermiculus commented 6 years ago

Fixes #281.

vermiculus commented 6 years ago

Merged as eb8a794df0db2e7edea1106a87bf03f94ec7e192.

stardiviner commented 6 years ago

I see. Thanks.