magithub-pull-request-new-arguments doesn't work if I have a heroku remote

[aaronjensen]

I'm not sure of the exact repro or issue, but here's what I've found. If I select "origin" from magithub-read-repo then magithub-repo-remotes-for-repo will return ("heroku" "origin") which is incorrect.

My remotes look something like this:

[remote "origin"]
        url = git@github.com:org/my-app.git
        fetch = +refs/heads/*:refs/remotes/origin/*
[remote "heroku"]
        url = https://git.heroku.com/my-app.git

The tests in here seem to pass:

               (and (string= .repo.owner.login
                             .remote.owner.login)
                    (string= .repo.name .remote.name))

[vermiculus]

What's the return of magithub--url->repo for each of those URLs? (I'd try myself, but I won't really be home until the weekend ☹️)

I bet #195 is related.

[aaronjensen]

origin -> ((owner (login . "org")) (name . "my-app")) heroku -> nil

And yea, #195 looks very similar.

[vermiculus]

And (magithub-repo-remotes-for-repo '((owner (login . "org")) (name . "my-app"))) returns ("heroku" "origin")?

[vermiculus]

Due to how magithub-repo-from-remote works, I think I'm getting false positives. Any chance you could provide my with the real URLs?

[aaronjensen]

@vermiculus yes, it returns ("heroku" "origin"). I emailed you the urls.

[vermiculus]

With those URLs, I was able to find the problem! Thanks again.

Here's an updated definition for magithub-repo-from-remote:

(defun magithub-repo-from-remote (remote)
  (when-let* ((repo (magithub-repo-from-remote--sparse remote)))
    (magithub-repo repo)))

Ping for @aspiers and @justinweiss -- can you try out the definition above to see if this will also fix #195?

[aaronjensen]

Thanks, that seems to work for me.