search

vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub
GNU General Public License v3.0
579 stars 63 forks source link

:condition-case must be a list of error handlers #301

Closed tarsius closed 6 years ago

tarsius commented 6 years ago

I think adapting to ghub's changes to the error handling is not complete. I get many errors like this when compiling magithub and one when compiling ghub+.

Eager macro-expansion failure: (error ":condition-case must be a list of error handlers; see the documentation: ((ghub-404 nil) (ghub-http-error (if (eq it 404) (progn nil) (signal (car it) (cdr it)))))")
vermiculus commented 6 years ago

There is a duplicate here; it has to do with trying to support old and new versions. Will fix tonight.

tarsius commented 6 years ago

Is it safe to just comment out that check for now?

vermiculus commented 6 years ago

vermiculus/ghub-plus#8

simendsjo commented 5 years ago

I get a similar issue. Deleted all packages and reinstalled them, to no luck.

Eager macro-expansion failure: (error ":condition-case must be a list of error handlers; see the documentation: ((ghub-422 (signal (quote ghubp-error-review-is-active) nil)) (ghub-http-error (let* ((val (car (cdr it)))) (if (eq val 422) (progn (signal (quote ghubp-error-review-is-active) nil)) (signal (car it) (cdr it))))))") [2 times]
apiwrap-gendefun: :condition-case must be a list of error handlers; see the documentation: ((ghub-422 (signal (quote ghubp-error-review-is-active) nil)) (ghub-http-error (let* ((val (car (cdr it)))) (if (eq val 422) (progn (signal (quote ghubp-error-review-is-active) nil)) (signal (car it) (cdr it))))))
vermiculus commented 5 years ago

Ack, this is a new issue from code I pushed last night. Please open a new ticket

vermiculus commented 5 years ago

I might be sending you a PR tonight, @tarsius

tarsius commented 5 years ago

I might be writing you an email tonight @vermiculus :stuck_out_tongue_winking_eye: