search

vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub
GNU General Public License v3.0
579 stars 63 forks source link

Use magit-unwind-refresh-hook to restore magithub-settings-cache-behavior-override #303

Closed tarsius closed 6 years ago

tarsius commented 6 years ago

This is cleaner and should be safer. However if an error occurs during refresh, then the hook might not be run, which could be addressed by adding a new magit-unwind-refresh-hook https://github.com/magit/magit/commit/ff517ea3733abac93a7d6ce27721e7685a045d49.

vermiculus commented 6 years ago

Added documentation to the magithub-reset-* function and fixed a comment in 78fe1ca.

vermiculus commented 6 years ago

Thanks for this; I like this solution a lot better – I didn't particularly enjoy relying on an idle timer 👍

I'll merge as soon as the compile statuses come back.

vermiculus commented 6 years ago

Confirmed compile errors are not related