Don't use debugging advice by default

[tarsius]

This line in magithub-core.el is probably a leftover and should be removed.

(advice-add #'ghub-request :around #'magithub-debug--ghub-request-wrapper)

As a side-note, that advice was pretty confusing when first running into it when debugging a bug in ghub itself, so I am currently removing it in my init file.

[vermiculus]

It wasn't unintentional; what problems is it causing?

[tarsius]

If a user reports a bug report against ghub or magit and has magithub loaded too, then the backtrace contains unrelated things, which makes it harder to figure out if the bug is in my code or not.

[vermiculus]

Would it be helpful if this were relegated to a command like magithub-instrument-for-debugging?

[tarsius]

Yes that would be great.

[tarsius]

Ping.

(I'll try to respond to your email soon.)

[vermiculus]

Thanks for the ping :-)