search

vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub
GNU General Public License v3.0
579 stars 62 forks source link

Alias magithub-dash-mode-map to magithub-dash-map #336

Open ashiklom opened 6 years ago

ashiklom commented 6 years ago

I'm still a bit new to Emacs so forgive my ignorance if I'm wrong...but I think the convention across most Emacs packages is that x-mode's keymap is x-mode-map, so the variable magithub-dash-map should probably be magithub-dash-mode-map, right?

For backwards compatibility, perhaps you could just alias magithub-dash-mode-map to magithub-dash-map?

For background, I ran into this issue when trying to bind some custom keys for the magithub dashboard via magithub-dash-mode-map. My keybindings showed up in the help when I did C-h m, but were not actually doing anything until I bound them to magithub-dash-map.

vermiculus commented 6 years ago

A fooey, you're absolutely right. I don't think an alias is necessary here since a stable version has not yet been released – or maybe we can add the alias and tell ourselves to remove it upon 1.0.