search

vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub
GNU General Public License v3.0
579 stars 62 forks source link

Temporarily disable require-final-newline when writing cache #343

Closed wyuenho closed 6 years ago

wyuenho commented 6 years ago

If the user has require-final-newline set to t, writing to any file will require a newline, but prin1-to-string doesn't output a newline, this PR temporarily disables it when writing to it so when I exit emacs, it won't prompt me to put a newline to the cache file.

wyuenho commented 6 years ago

@vermiculus how does this look?

vermiculus commented 6 years ago

It's fantastic; thank you :-) I've just been going a little crazy lately.

vermiculus commented 6 years ago

Merged; thanks again!

wyuenho commented 6 years ago

Melpa doesn't seem to have picked up the latest merged, any idea why?

vermiculus commented 6 years ago

Honestly, no ... it doesn't seem to have picked anything up for quite some time. I'll raise an issue for this -- thanks for noticing!

For now you can advise-around magithub-cache-write-to-disk to let-bind that variable.