search

vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub
GNU General Public License v3.0
579 stars 63 forks source link

Set up magithub-edit-mode after associating draft with a file #345

Closed asf-stripe closed 6 years ago

asf-stripe commented 6 years ago

When restoring from a draft (even if the file doesn't exist), setting the buffer's file clears the major mode for some reason. Setting up magithub-edit-mode after associating the draft buffer fixes this problem, and makes magithub edit mode buffers come up in the right mode regardless of whether there was a draft file associated with them or not.

vermiculus commented 6 years ago

I'm noticing this now, too. It could be some change in how those functions work between Emacs 25 and 26; I'm not sure.

Thanks for the patch – I've got a very messy working copy right now, but once that's cleaned up I'll make sure this gets tested/merged. Thanks so much!

vermiculus commented 6 years ago

Works like a charm; thanks!

vermiculus commented 6 years ago

Merged; thanks again!