search

vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub
GNU General Public License v3.0
579 stars 63 forks source link

Sorting is not applied #354

Open vspinu opened 6 years ago

vspinu commented 6 years ago

AFAICS magithub-issue--sort is never called.

I have 

(defun my-magithub-issue-sort-updated-ascending (a b)
  (time-less-p (date-to-time (alist-get 'updated_at a))
               (date-to-time (alist-get 'updated_at b))))

(setq magithub-issue-sort-function #'my-magithub-issue-sort-updated-ascending)

BTW, would be nice to have such a sort function as part of magithub itself. It's a common pattern. Even better, would be great to have toggling of the sorting type inside the status buffer. Would you like to have a separate issue for that?

vermiculus commented 6 years ago

Regarding default sorts, there's an issue for that already. I'd like to realize some concept of issue 'views' that can be switched between, but sadly I've not had the time for this project as I once did.

vspinu commented 6 years ago

Here it is #124. Would be great indeed!