search

vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub
GNU General Public License v3.0
579 stars 62 forks source link

Missing quotes in calls to magit-insert-headers #359

Closed duog closed 5 years ago

duog commented 5 years ago

It seems that your two calls to magit-insert-headers in magithub-dash.el and magithub-issue-view should quote the hook variable.

I see the following:

magit-insert-headers: Wrong type argument: symbolp, (magithub-dash-insert-user-name-header magithub-dash-insert-ratelimit-header magithub-maybe-report-offline-mode)

When opening the magithub dashboard, and adding said quotes seems to fix it.

I'm on linux, emacs 26.1 and am getting magithub from melpa.

seanfarley commented 5 years ago

I was about to open the same issue since I just hit this; so I'm just here to confirm!

vermiculus commented 5 years ago

It's odd that this is happening all of a sudden. @tarsius – did I miss a plumping change upstream? I haven't updated magit in a few days (lagging about a week behind) and everything's working fine for me.

tarsius commented 5 years ago

Maybe this is related to https://github.com/magit/magit/pull/3539. There was an issue with that, https://github.com/magit/magit/issues/3542, which was fixed, so @duog please update magit before we investigate any further.

duog commented 5 years ago

I'm still pretty new to emacs, so I hope I've not done something silly. I am running doom-emacs, and have updated and cleaned everything I know how to do. My elpa dir has

magit-20180809.1716
magithub-20180804.19

and this issue persists.

duog commented 5 years ago

Pretty sure it's https://github.com/magit/magit/commit/2fc79d0826575017b09c2d3a26980f0fa5dfaf8d

tarsius commented 5 years ago

Indeed. @vermiculus you'll have to quote the argument to magit-insert-headers.