vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub
GNU General Public License v3.0
579 stars 62 forks source link

"There is no thing at point that could be edited" when trying to edit an issue #368

Open DrWaleedAYousef opened 5 years ago

DrWaleedAYousef commented 5 years ago

When "enter" an issue, then try to edit it (not commenting) this message is given in the mini-buffer: "There is no thing at point that could be edited"

vermiculus commented 5 years ago

This is not yet supported.

DrWaleedAYousef commented 5 years ago

So you mean I only can create a new issue from magithub but cannot edit it; right?

vermiculus commented 5 years ago

As of today, yes. This could change in the future provided I find the time to implement it (or some brave soul submits a PR).

DrWaleedAYousef commented 5 years ago

Thanks so much

vermiculus commented 5 years ago

Leaving open as an enhancement.

ccressent commented 5 years ago

Any chance we can change the message in the meantime?

I too was scratching my head about "nothing at point that could be edited" when trying to edit an issue :(

vermiculus commented 5 years ago

It's a standard message provided by magithub-edit-thing. I'd be fine with changing the message, but it would need to make sense for anything you might want to edit.

ccressent commented 5 years ago

I'm a beginner elisper, but it looks like magithub-edit-thing is purely and simply not implemented (source here)? What about changing the error to something like "This operation is not supported yet."?

I imagine that down the road, magithub-edit-thing is going to look at what's at point and call different functions accordingly, ie: magithub-comment-edit if it's a comment, ...?

vermiculus commented 5 years ago

Not quite. In fact, magithub-edit-thing is remapped to different functions in different keymaps.

ccressent commented 5 years ago

I see, now I understand better your dilemma with changing the message!

ibizaman commented 5 years ago

https://github.com/vermiculus/magithub/pull/386 implements this issue