search

vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub
GNU General Public License v3.0
579 stars 63 forks source link

magithub-browse-file-blame #378

Open stardiviner opened 6 years ago

stardiviner commented 6 years ago

This is a new continue of issue https://github.com/vermiculus/magithub/pull/377#issuecomment-423781610 The command magithub-browse-file-blame opened URL with wrong commit hash.

vermiculus commented 6 years ago

That function uses the full hash of HEAD for the URL. What is that hash? git rev-parse HEAD

stardiviner commented 6 years ago

It is f92a80c18ddc7faae5ed30c76cad47bd4551607f result from git rev-parse HEAD.

stardiviner commented 6 years ago

I will take a look at github-browse-file-blame tomorrow.

stardiviner commented 6 years ago

I checked out github-browse-file-blame. Have not found any obviously different with magithub-browse-file-blame. magithub-browse-file-blame use git re-parse HEAD. But github-browse-blame seems does not use that. I can't find where it get the commit hash. weird. I checked function github-browse-file--browse-url, not found.