search

vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub
GNU General Public License v3.0
579 stars 63 forks source link

Don't try to add action to non-existent Magit popup #383

Closed tarsius closed 6 years ago

tarsius commented 6 years ago

Later this year magit will start using transient instead of magit-popup. Extensions to magit may continue to use magit-popup but they cannot add any additional actions to magit's popups because there no longer are any such popups.

transient does not yet allow adding new suffix commands to existing prefix commands.

Also make sure magit-popup is loaded before trying to use a function defined by it, preventing an error when it is not.

vermiculus commented 6 years ago

Thanks! Looking forward to transient 😄