search

vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub
GNU General Public License v3.0
579 stars 63 forks source link

Allow to edit issue and pull request title and body #386

Closed ibizaman closed 4 years ago

ibizaman commented 6 years ago

Adds enhancement for issue #385.

I don't really know what to show you as test apart from saying I edited this PR and the related issue by pressing e when viewing the issue. I could correctly change the title and body of the issue/PR.

vermiculus commented 6 years ago

Beautiful; I'll pull and test these changes tonight. Thanks!

ibizaman commented 6 years ago

Btw I don't think there's a need to change the manual as it is IMO already suggesting one can do what this PR adds.

Stebalien commented 5 years ago

@vermiculus (FYI, this is ready for a second review)

vermiculus commented 5 years ago

Reviewing now; thanks for your patience :-) There will likely be a few things I want to change in the implementation -- is it alright if I push to your branch?

I will say that I ultimately intend to remove issue- and PR-creating capability from Magithub in favor of Forge functionality.

ibizaman commented 5 years ago

@vermiculus yes of course!

JustinD85 commented 5 years ago

Any chance this can get merged?

vermiculus commented 5 years ago

At this time I recommend moving to Forge (which I believe supports this; I may be wrong) unless you have a particular reason you need to keep using Magithub.

ibizaman commented 5 years ago

No reason apart nostalgia. Should I switch completely to Forge?

vermiculus commented 5 years ago

You're free to keep using magithub of course :-) but I have every intention of discontinuing it and pulling it from MELPA by the end of the year.

This may seem drastic but I feel pretty strongly about not fracturing the community with competing, incompatible solutions.

ibizaman commented 4 years ago

Agreed on not fracturing. I moved to forge in the meantime. Thanks for maintaining this project!