Magit will soon start to use transient instead of magit-popup, but I recommend that you stick to magit-popup for a while before switching too. You will have to depend on magit-popup explicitly and might as well do that now.
When I make the switch I will also remove some popup-related helper functions from magit. You should copy those to magithub for the time being:
magithub-settings.el:383:1:Warning: the following functions are not known to
be defined: magit--set-popup-variable,
magit--format-popup-variable:choices
Some more functions will disappear:
magithub-issue.el:662:1:Warning: the function ‘magit-checkout-pull-request’ is
not known to be defined.
magithub.el:420:1:Warning: the following functions are not known to be
defined: magit-push-popup, magit-set-branch*merge/remote
Different approaches will be needed here. For the time being you should just make sure that these functions are not called if they do not exist.
tarsius
commented
5 years ago
Magit will soon start to use
transientinstead ofmagit-popup, but I recommend that you stick tomagit-popupfor a while before switching too. You will have to depend onmagit-popupexplicitly and might as well do that now.When I make the switch I will also remove some popup-related helper functions from
magit. You should copy those tomagithubfor the time being:Some more functions will disappear:
Different approaches will be needed here. For the time being you should just make sure that these functions are not called if they do not exist.