magithub-feature-autoinject error

vermiculus / magithub

**DEPRECATED - please use Forge instead!** -- Magit-based interfaces to GitHub

GNU General Public License v3.0

579 stars 63 forks source link

magithub-feature-autoinject error #402

Closed mgcyung closed 5 years ago

mgcyung commented 5 years ago

Emacs initialization breaks down on

(after-load 'magit (magithub-feature-autoinject t))

with error

error: feature pull-request-merge failed to install: nil

It seems due to no defination of function "magit-am-popup". Since https://github.com/magit/magit/pull/3728 magit uses Transient instead of Magit-Popup.

vermiculus commented 5 years ago

You're right; magithub will need to be ported to transient. I'm unlikely to do this anytime in the next few days ago (what little free time I have, I'm putting into Forge) – do you want to take a crack at a PR? You'll want to adjust magithub-feature-list in magithub-core.el.