void-variable magithub-settings-popup

benwainwright commented 5 years ago

Getting this error when trying to load Magithub:

Debugger entered--Lisp error: (void-variable magithub-settings-popup)
  byte-code("\301\302\303\304#\305\010\306\307#\207" [magithub-settings-popup function-put magithub-settings--value-or lisp-indent-function 2 magit-define-popup "Popup console for managing Magithub settings." magithub-commands] 5)
  require(magithub-settings)
  eval-buffer(#<buffer  *load*-956471> nil "/Users/wainwb01/.emacs.d/elpa/magithub-20190118.2147/magithub-core.el" nil t)  ; Reading at buffer position 1150
  load-with-code-conversion("/Users/wainwb01/.emacs.d/elpa/magithub-20190118.2147/magithub-core.el" "/Users/wainwb01/.emacs.d/elpa/magithub-20190118.2147/magithub-core.el" nil t)
  require(magithub-core)
  eval-buffer(#<buffer  *load*-996215> nil "/Users/wainwb01/.emacs.d/elpa/magithub-20190118.2147/magithub.el" nil t)  ; Reading at buffer position 1847
  load-with-code-conversion("/Users/wainwb01/.emacs.d/elpa/magithub-20190118.2147/magithub.el" "/Users/wainwb01/.emacs.d/elpa/magithub-20190118.2147/magithub.el" t t)
  require(magithub nil t)
  (not (require 'magithub nil t))
  (if (not (require 'magithub nil t)) (display-warning 'use-package (format "Cannot load %s" 'magithub) :error) (condition-case err (progn (magithub-feature-autoinject t) (setq magithub-clone-default-directory "~/workspace") t) ((debug error) (funcall use-package--warning16 :config err))))
  (lambda nil (if (not (require 'magithub nil t)) (display-warning 'use-package (format "Cannot load %s" 'magithub) :error) (condition-case err (progn (magithub-feature-autoinject t) (setq magithub-clone-default-directory "~/workspace") t) ((debug error) (funcall use-package--warning16 :config err)))))()
  eval-after-load(magit (lambda nil (if (not (require 'magithub nil t)) (display-warning 'use-package (format "Cannot load %s" 'magithub) :error) (condition-case err (progn (magithub-feature-autoinject t) (setq magithub-clone-default-directory "~/workspace") t) ((debug error) (funcall use-package--warning16 :config err))))))
  (lambda nil (eval-after-load 'magit (function (lambda nil (if (not (require 'magithub nil t)) (display-warning 'use-package (format "Cannot load %s" 'magithub) :error) (condition-case err (progn (magithub-feature-autoinject t) (setq magithub-clone-default-directory "~/workspace") t) ((debug error) (funcall use-package--warning16 :config err))))))))()
  eval-after-load(magit-popup (lambda nil (eval-after-load 'magit (function (lambda nil (if (not (require 'magithub nil t)) (display-warning 'use-package (format "Cannot load %s" 'magithub) :error) (condition-case err (progn (magithub-feature-autoinject t) (setq magithub-clone-default-directory "~/workspace") t) ((debug error) (funcall use-package--warning16 :config err)))))))))
  (condition-case err (eval-after-load 'magit-popup (function (lambda nil (eval-after-load 'magit (function (lambda nil (if (not (require 'magithub nil t)) (display-warning 'use-package (format "Cannot load %s" 'magithub) :error) (condition-case err (progn (magithub-feature-autoinject t) (setq magithub-clone-default-directory "~/workspace") t) ((debug error) (funcall use-package--warning16 :config err)))))))))) ((debug error) (funcall use-package--warning16 :catch err)))
  eval-buffer(#<buffer  *load*-814474> nil "/Users/wainwb01/.emacs.d/config/packages.el" nil t)  ; Reading at buffer position 2332
  load-with-code-conversion("/Users/wainwb01/.emacs.d/config/packages.el" "/Users/wainwb01/.emacs.d/config/packages.el" nil nil)
  load("packages")
  eval-buffer(#<buffer  *load*> nil "/Users/wainwb01/.emacs.d/init.el" nil t)  ; Reading at buffer position 119
  load-with-code-conversion("/Users/wainwb01/.emacs.d/init.el" "/Users/wainwb01/.emacs.d/init.el" t t)
  load("/Users/wainwb01/.emacs.d/init" t t)
  #f(compiled-function () #<bytecode 0x400d3941>)()
  command-line()
  normal-top-level()

vermiculus commented 5 years ago

I can take a look at this sometime next week, but I encourage you to migrate to Forge. If there's functionality you would sorely miss from Magithub, let me know and I can see if I can add it into Forge.

benwainwright commented 5 years ago

@vermiculus Apologies, I hadn't looked closely at what Forge was. Will have a dig right now.

mddavila commented 5 years ago

@vermiculus could you please include status checks (e.g., CI) and notifications in Forge? I would really appreciate that. Many thanks!

vermiculus commented 5 years ago

Notifications exist already; CI status is being tracked in magit/forge#92

benwainwright commented 5 years ago

@vermiculus I'm using Forge now and it does everything I wanted! Thanks.

Haven't closed this because I assume the bug is still present in Magithub so I'll leave that up to you.

vermiculus commented 5 years ago

Great to hear! I'll leave this open, but I intend to archive the entire project once Forge has everything Magithub has ever provided.

titaniumbones commented 5 years ago

@vermiculus I'm seeing something similar with magithub-create which is right now I think the only thing I'm not using forge for. Is forge able to create github repos? if so I can't find the command, and I also don't see in forge or ghub anything analogous to the ghubp-post-user-repos command that magithub-create uses to create a repo

Filing here rather than elsewhere b/c I think the underlying issue still has to do with the absence of popups in newer versions of magit (now using transient). Thanks as always for the help.

tarsius commented 5 years ago

Probably all you need to do is to add magit-popup to the Package-Requires library header.

vermiculus / magithub

void-variable magithub-settings-popup #404