Emacs 29 & Magithub Error: void symbol 'magithub-pull-requests-list'

[seanhagen]

Trying out Emacs 29 and I'm running into this error after having straight update all the repos:

Debugger entered--Lisp error: (void-function magithub-pull-requests-list)
  magithub-pull-requests-list()
  magithub-issue--insert-pr-section()
  magit-run-section-hook(magit-status-sections-hook)
  magit-status-refresh-buffer()
  magit-refresh-buffer()
  magit-setup-buffer-internal(magit-status-mode nil ((magit-buffer-diff-args ("--no-ext-diff")) (magit-buffer-diff-files nil) (magit-buffer-log-args ("-n256" "--decorate")) (magit-buffer-log-files nil)))
  magit-status-setup-buffer("/home/sean/.emacs.d/modes/")
  #<subr magit-status>(nil ((118 . 32) (("/home/sean/.emacs.d/" "symbolic-ref" #("refs/remotes/origin/HEAD" 13 19 (face magit-branch-remote font-lock-face magit-branch-remote)))) (("/home/sean/.emacs.d/" "rev-parse" "--short" "HEAD~") . "35bc4b5") (("/home/sean/.emacs.d/" "rev-parse" "--short" "HEAD") . "a1dbea9") (("/home/sean/.emacs.d/" "rev-parse" "--verify" "HEAD~10") . "29d1e3a54bad380f4bd425e3a32b8c9dba3fb288") (magit--insert-pushremote-log-p) ((magit-get-upstream-branch nil) . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) ((magit-get-push-branch nil nil) . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) (("/home/sean/.emacs.d/" "rev-parse" "--verify" "refs/stash") . "c24699ce354751cdeb8a62c200eb559c14335d09") (("/home/sean/.emacs.d/" "rev-parse" "--is-bare-repository") . "false\n") (("/home/sean/.emacs.d/" magit-git-dir "BISECT_LOG") . "/home/sean/.emacs.d/.git/BISECT_LOG") (("/home/sean/.emacs.d/" magit-git-dir "REVERT_HEAD") . "/home/sean/.emacs.d/.git/REVERT_HEAD") (("/home/sean/.emacs.d/" magit-git-dir "CHERRY_PICK_HEAD") . "/home/sean/.emacs.d/.git/CHERRY_PICK_HEAD") (("/home/sean/.emacs.d/" magit-git-dir "rebase-apply/applying") . "/home/sean/.emacs.d/.git/rebase-apply/applying") (("/home/sean/.emacs.d/" magit-git-dir "MERGE_HEAD") . "/home/sean/.emacs.d/.git/MERGE_HEAD") (("/home/sean/.emacs.d/" magit-git-dir "rebase-apply/onto") . "/home/sean/.emacs.d/.git/rebase-apply/onto") (("/home/sean/.emacs.d/" magit-git-dir "rebase-merge") . "/home/sean/.emacs.d/.git/rebase-merge") (("/home/sean/.emacs.d/" "rev-parse" "--git-dir") . ".git") (("/home/sean/.emacs.d/" "describe" "--contains" "HEAD")) (("/home/sean/.emacs.d/" "describe" "--long" "--tags")) (("/home/sean/.emacs.d/" "rev-parse" "--verify" #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) . "a1dbea91bc54748f1cd3a5adec0e9ffe28fd3d14") ((magit-get-push-branch "main" nil) . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) (("/home/sean/.emacs.d/" "show" "--no-patch" "--format=%s" #("origin/main^{commit}" 0 11 (font-lock-face magit-branch-remote face magit-branch-remote)) "--") . "Add function for generating UUID") ((magit-get-upstream-branch "main") . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) (("/home/sean/.emacs.d/" "rev-parse" "--verify" "--abbrev-ref" "main@{upstream}") . "origin/main") (("/home/sean/.emacs.d/" "show" "--no-patch" "--format=%h %s" "HEAD^{commit}" "--") . "a1dbea9 Add function for generating UUID") (("/home/sean/.emacs.d/" "symbolic-ref" "--short" "HEAD") . "main") (("/home/sean/.emacs.d/" . config) . #<hash-table equal 32/65 0x158d07d17b75>) (("/home/sean/.emacs.d/" . magit-toplevel) . "/home/sean/.emacs.d/") (("/home/sean/.emacs.d/" "rev-parse" "--verify" "HEAD") . "a1dbea91bc54748f1cd3a5adec0e9ffe28fd3d14") (("/home/sean/.emacs.d/" "rev-parse" "--show-toplevel") . "/home/sean/.emacs.d") (("/home/sean/.emacs.d/modes/" . magit-toplevel) . "/home/sean/.emacs.d/") (("/home/sean/.emacs.d/modes/" "rev-parse" "--show-toplevel") . "/home/sean/.emacs.d")))
  ad-Advice-magit-status(#<subr magit-status> nil ((118 . 32) (("/home/sean/.emacs.d/" "symbolic-ref" #("refs/remotes/origin/HEAD" 13 19 (face magit-branch-remote font-lock-face magit-branch-remote)))) (("/home/sean/.emacs.d/" "rev-parse" "--short" "HEAD~") . "35bc4b5") (("/home/sean/.emacs.d/" "rev-parse" "--short" "HEAD") . "a1dbea9") (("/home/sean/.emacs.d/" "rev-parse" "--verify" "HEAD~10") . "29d1e3a54bad380f4bd425e3a32b8c9dba3fb288") (magit--insert-pushremote-log-p) ((magit-get-upstream-branch nil) . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) ((magit-get-push-branch nil nil) . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) (("/home/sean/.emacs.d/" "rev-parse" "--verify" "refs/stash") . "c24699ce354751cdeb8a62c200eb559c14335d09") (("/home/sean/.emacs.d/" "rev-parse" "--is-bare-repository") . "false\n") (("/home/sean/.emacs.d/" magit-git-dir "BISECT_LOG") . "/home/sean/.emacs.d/.git/BISECT_LOG") (("/home/sean/.emacs.d/" magit-git-dir "REVERT_HEAD") . "/home/sean/.emacs.d/.git/REVERT_HEAD") (("/home/sean/.emacs.d/" magit-git-dir "CHERRY_PICK_HEAD") . "/home/sean/.emacs.d/.git/CHERRY_PICK_HEAD") (("/home/sean/.emacs.d/" magit-git-dir "rebase-apply/applying") . "/home/sean/.emacs.d/.git/rebase-apply/applying") (("/home/sean/.emacs.d/" magit-git-dir "MERGE_HEAD") . "/home/sean/.emacs.d/.git/MERGE_HEAD") (("/home/sean/.emacs.d/" magit-git-dir "rebase-apply/onto") . "/home/sean/.emacs.d/.git/rebase-apply/onto") (("/home/sean/.emacs.d/" magit-git-dir "rebase-merge") . "/home/sean/.emacs.d/.git/rebase-merge") (("/home/sean/.emacs.d/" "rev-parse" "--git-dir") . ".git") (("/home/sean/.emacs.d/" "describe" "--contains" "HEAD")) (("/home/sean/.emacs.d/" "describe" "--long" "--tags")) (("/home/sean/.emacs.d/" "rev-parse" "--verify" #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) . "a1dbea91bc54748f1cd3a5adec0e9ffe28fd3d14") ((magit-get-push-branch "main" nil) . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) (("/home/sean/.emacs.d/" "show" "--no-patch" "--format=%s" #("origin/main^{commit}" 0 11 (font-lock-face magit-branch-remote face magit-branch-remote)) "--") . "Add function for generating UUID") ((magit-get-upstream-branch "main") . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) (("/home/sean/.emacs.d/" "rev-parse" "--verify" "--abbrev-ref" "main@{upstream}") . "origin/main") (("/home/sean/.emacs.d/" "show" "--no-patch" "--format=%h %s" "HEAD^{commit}" "--") . "a1dbea9 Add function for generating UUID") (("/home/sean/.emacs.d/" "symbolic-ref" "--short" "HEAD") . "main") (("/home/sean/.emacs.d/" . config) . #<hash-table equal 32/65 0x158d07d17b75>) (("/home/sean/.emacs.d/" . magit-toplevel) . "/home/sean/.emacs.d/") (("/home/sean/.emacs.d/" "rev-parse" "--verify" "HEAD") . "a1dbea91bc54748f1cd3a5adec0e9ffe28fd3d14") (("/home/sean/.emacs.d/" "rev-parse" "--show-toplevel") . "/home/sean/.emacs.d") (("/home/sean/.emacs.d/modes/" . magit-toplevel) . "/home/sean/.emacs.d/") (("/home/sean/.emacs.d/modes/" "rev-parse" "--show-toplevel") . "/home/sean/.emacs.d")))
  apply(ad-Advice-magit-status #<subr magit-status> (nil ((118 . 32) (("/home/sean/.emacs.d/" "symbolic-ref" #("refs/remotes/origin/HEAD" 13 19 (face magit-branch-remote font-lock-face magit-branch-remote)))) (("/home/sean/.emacs.d/" "rev-parse" "--short" "HEAD~") . "35bc4b5") (("/home/sean/.emacs.d/" "rev-parse" "--short" "HEAD") . "a1dbea9") (("/home/sean/.emacs.d/" "rev-parse" "--verify" "HEAD~10") . "29d1e3a54bad380f4bd425e3a32b8c9dba3fb288") (magit--insert-pushremote-log-p) ((magit-get-upstream-branch nil) . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) ((magit-get-push-branch nil nil) . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) (("/home/sean/.emacs.d/" "rev-parse" "--verify" "refs/stash") . "c24699ce354751cdeb8a62c200eb559c14335d09") (("/home/sean/.emacs.d/" "rev-parse" "--is-bare-repository") . "false\n") (("/home/sean/.emacs.d/" magit-git-dir "BISECT_LOG") . "/home/sean/.emacs.d/.git/BISECT_LOG") (("/home/sean/.emacs.d/" magit-git-dir "REVERT_HEAD") . "/home/sean/.emacs.d/.git/REVERT_HEAD") (("/home/sean/.emacs.d/" magit-git-dir "CHERRY_PICK_HEAD") . "/home/sean/.emacs.d/.git/CHERRY_PICK_HEAD") (("/home/sean/.emacs.d/" magit-git-dir "rebase-apply/applying") . "/home/sean/.emacs.d/.git/rebase-apply/applying") (("/home/sean/.emacs.d/" magit-git-dir "MERGE_HEAD") . "/home/sean/.emacs.d/.git/MERGE_HEAD") (("/home/sean/.emacs.d/" magit-git-dir "rebase-apply/onto") . "/home/sean/.emacs.d/.git/rebase-apply/onto") (("/home/sean/.emacs.d/" magit-git-dir "rebase-merge") . "/home/sean/.emacs.d/.git/rebase-merge") (("/home/sean/.emacs.d/" "rev-parse" "--git-dir") . ".git") (("/home/sean/.emacs.d/" "describe" "--contains" "HEAD")) (("/home/sean/.emacs.d/" "describe" "--long" "--tags")) (("/home/sean/.emacs.d/" "rev-parse" "--verify" #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) . "a1dbea91bc54748f1cd3a5adec0e9ffe28fd3d14") ((magit-get-push-branch "main" nil) . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) (("/home/sean/.emacs.d/" "show" "--no-patch" "--format=%s" #("origin/main^{commit}" 0 11 (font-lock-face magit-branch-remote face magit-branch-remote)) "--") . "Add function for generating UUID") ((magit-get-upstream-branch "main") . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) (("/home/sean/.emacs.d/" "rev-parse" "--verify" "--abbrev-ref" "main@{upstream}") . "origin/main") (("/home/sean/.emacs.d/" "show" "--no-patch" "--format=%h %s" "HEAD^{commit}" "--") . "a1dbea9 Add function for generating UUID") (("/home/sean/.emacs.d/" "symbolic-ref" "--short" "HEAD") . "main") (("/home/sean/.emacs.d/" . config) . #<hash-table equal 32/65 0x158d07d17b75>) (("/home/sean/.emacs.d/" . magit-toplevel) . "/home/sean/.emacs.d/") (("/home/sean/.emacs.d/" "rev-parse" "--verify" "HEAD") . "a1dbea91bc54748f1cd3a5adec0e9ffe28fd3d14") (("/home/sean/.emacs.d/" "rev-parse" "--show-toplevel") . "/home/sean/.emacs.d") (("/home/sean/.emacs.d/modes/" . magit-toplevel) . "/home/sean/.emacs.d/") (("/home/sean/.emacs.d/modes/" "rev-parse" "--show-toplevel") . "/home/sean/.emacs.d"))))
  magit-status(nil ((118 . 32) (("/home/sean/.emacs.d/" "symbolic-ref" #("refs/remotes/origin/HEAD" 13 19 (face magit-branch-remote font-lock-face magit-branch-remote)))) (("/home/sean/.emacs.d/" "rev-parse" "--short" "HEAD~") . "35bc4b5") (("/home/sean/.emacs.d/" "rev-parse" "--short" "HEAD") . "a1dbea9") (("/home/sean/.emacs.d/" "rev-parse" "--verify" "HEAD~10") . "29d1e3a54bad380f4bd425e3a32b8c9dba3fb288") (magit--insert-pushremote-log-p) ((magit-get-upstream-branch nil) . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) ((magit-get-push-branch nil nil) . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) (("/home/sean/.emacs.d/" "rev-parse" "--verify" "refs/stash") . "c24699ce354751cdeb8a62c200eb559c14335d09") (("/home/sean/.emacs.d/" "rev-parse" "--is-bare-repository") . "false\n") (("/home/sean/.emacs.d/" magit-git-dir "BISECT_LOG") . "/home/sean/.emacs.d/.git/BISECT_LOG") (("/home/sean/.emacs.d/" magit-git-dir "REVERT_HEAD") . "/home/sean/.emacs.d/.git/REVERT_HEAD") (("/home/sean/.emacs.d/" magit-git-dir "CHERRY_PICK_HEAD") . "/home/sean/.emacs.d/.git/CHERRY_PICK_HEAD") (("/home/sean/.emacs.d/" magit-git-dir "rebase-apply/applying") . "/home/sean/.emacs.d/.git/rebase-apply/applying") (("/home/sean/.emacs.d/" magit-git-dir "MERGE_HEAD") . "/home/sean/.emacs.d/.git/MERGE_HEAD") (("/home/sean/.emacs.d/" magit-git-dir "rebase-apply/onto") . "/home/sean/.emacs.d/.git/rebase-apply/onto") (("/home/sean/.emacs.d/" magit-git-dir "rebase-merge") . "/home/sean/.emacs.d/.git/rebase-merge") (("/home/sean/.emacs.d/" "rev-parse" "--git-dir") . ".git") (("/home/sean/.emacs.d/" "describe" "--contains" "HEAD")) (("/home/sean/.emacs.d/" "describe" "--long" "--tags")) (("/home/sean/.emacs.d/" "rev-parse" "--verify" #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) . "a1dbea91bc54748f1cd3a5adec0e9ffe28fd3d14") ((magit-get-push-branch "main" nil) . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) (("/home/sean/.emacs.d/" "show" "--no-patch" "--format=%s" #("origin/main^{commit}" 0 11 (font-lock-face magit-branch-remote face magit-branch-remote)) "--") . "Add function for generating UUID") ((magit-get-upstream-branch "main") . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) (("/home/sean/.emacs.d/" "rev-parse" "--verify" "--abbrev-ref" "main@{upstream}") . "origin/main") (("/home/sean/.emacs.d/" "show" "--no-patch" "--format=%h %s" "HEAD^{commit}" "--") . "a1dbea9 Add function for generating UUID") (("/home/sean/.emacs.d/" "symbolic-ref" "--short" "HEAD") . "main") (("/home/sean/.emacs.d/" . config) . #<hash-table equal 32/65 0x158d07d17b75>) (("/home/sean/.emacs.d/" . magit-toplevel) . "/home/sean/.emacs.d/") (("/home/sean/.emacs.d/" "rev-parse" "--verify" "HEAD") . "a1dbea91bc54748f1cd3a5adec0e9ffe28fd3d14") (("/home/sean/.emacs.d/" "rev-parse" "--show-toplevel") . "/home/sean/.emacs.d") (("/home/sean/.emacs.d/modes/" . magit-toplevel) . "/home/sean/.emacs.d/") (("/home/sean/.emacs.d/modes/" "rev-parse" "--show-toplevel") . "/home/sean/.emacs.d")))
  funcall-interactively(magit-status nil ((118 . 32) (("/home/sean/.emacs.d/" "symbolic-ref" #("refs/remotes/origin/HEAD" 13 19 (face magit-branch-remote font-lock-face magit-branch-remote)))) (("/home/sean/.emacs.d/" "rev-parse" "--short" "HEAD~") . "35bc4b5") (("/home/sean/.emacs.d/" "rev-parse" "--short" "HEAD") . "a1dbea9") (("/home/sean/.emacs.d/" "rev-parse" "--verify" "HEAD~10") . "29d1e3a54bad380f4bd425e3a32b8c9dba3fb288") (magit--insert-pushremote-log-p) ((magit-get-upstream-branch nil) . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) ((magit-get-push-branch nil nil) . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) (("/home/sean/.emacs.d/" "rev-parse" "--verify" "refs/stash") . "c24699ce354751cdeb8a62c200eb559c14335d09") (("/home/sean/.emacs.d/" "rev-parse" "--is-bare-repository") . "false\n") (("/home/sean/.emacs.d/" magit-git-dir "BISECT_LOG") . "/home/sean/.emacs.d/.git/BISECT_LOG") (("/home/sean/.emacs.d/" magit-git-dir "REVERT_HEAD") . "/home/sean/.emacs.d/.git/REVERT_HEAD") (("/home/sean/.emacs.d/" magit-git-dir "CHERRY_PICK_HEAD") . "/home/sean/.emacs.d/.git/CHERRY_PICK_HEAD") (("/home/sean/.emacs.d/" magit-git-dir "rebase-apply/applying") . "/home/sean/.emacs.d/.git/rebase-apply/applying") (("/home/sean/.emacs.d/" magit-git-dir "MERGE_HEAD") . "/home/sean/.emacs.d/.git/MERGE_HEAD") (("/home/sean/.emacs.d/" magit-git-dir "rebase-apply/onto") . "/home/sean/.emacs.d/.git/rebase-apply/onto") (("/home/sean/.emacs.d/" magit-git-dir "rebase-merge") . "/home/sean/.emacs.d/.git/rebase-merge") (("/home/sean/.emacs.d/" "rev-parse" "--git-dir") . ".git") (("/home/sean/.emacs.d/" "describe" "--contains" "HEAD")) (("/home/sean/.emacs.d/" "describe" "--long" "--tags")) (("/home/sean/.emacs.d/" "rev-parse" "--verify" #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) . "a1dbea91bc54748f1cd3a5adec0e9ffe28fd3d14") ((magit-get-push-branch "main" nil) . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) (("/home/sean/.emacs.d/" "show" "--no-patch" "--format=%s" #("origin/main^{commit}" 0 11 (font-lock-face magit-branch-remote face magit-branch-remote)) "--") . "Add function for generating UUID") ((magit-get-upstream-branch "main") . #("origin/main" 0 11 (face magit-branch-remote font-lock-face magit-branch-remote))) (("/home/sean/.emacs.d/" "rev-parse" "--verify" "--abbrev-ref" "main@{upstream}") . "origin/main") (("/home/sean/.emacs.d/" "show" "--no-patch" "--format=%h %s" "HEAD^{commit}" "--") . "a1dbea9 Add function for generating UUID") (("/home/sean/.emacs.d/" "symbolic-ref" "--short" "HEAD") . "main") (("/home/sean/.emacs.d/" . config) . #<hash-table equal 32/65 0x158d07d17b75>) (("/home/sean/.emacs.d/" . magit-toplevel) . "/home/sean/.emacs.d/") (("/home/sean/.emacs.d/" "rev-parse" "--verify" "HEAD") . "a1dbea91bc54748f1cd3a5adec0e9ffe28fd3d14") (("/home/sean/.emacs.d/" "rev-parse" "--show-toplevel") . "/home/sean/.emacs.d") (("/home/sean/.emacs.d/modes/" . magit-toplevel) . "/home/sean/.emacs.d/") (("/home/sean/.emacs.d/modes/" "rev-parse" "--show-toplevel") . "/home/sean/.emacs.d")))
  command-execute(magit-status)

Here's the relevant section of my config file:

(defadvice magit-status
    (around magit-fullscreen activate)
  (window-configuration-to-register :magit-fullscreen)
  ad-do-it
  (delete-other-windows))

(defun magit-quit-session ()
  "Restore the previous window configuration and kill the magit buffer."
  (interactive)
  (kill-buffer)
  (jump-to-register :magit-fullscreen))

(use-package magit
  :diminish magit-auto-revert-mode
  :defer 
  :no-require t
  :commands magit-status
  :bind (("C-x m" . magit-status)
         :map magit-status-mode-map
         ("q" . magit-quit-session))
  :config
  (setq magit-last-seen-setup-instructions "1.4.0"
        vc-handled-backends nil
        magit-auto-revert-mode 1
        transient-default-level 5)
  (add-hook 'git-commit-mode-hook 'turn-on-flyspell)
  (set-face-background 'diff-file-header "#121212")
  (set-face-foreground 'diff-context "#666666")
  (set-face-foreground 'diff-added "#00cc33")
  (set-face-foreground 'diff-removed "#ff0000")
  (set-default 'magit-stage-all-confirm nil)
  (set-default 'magit-unstage-all-confirm nil))

(use-package magithub
  :after magit
  :config (magithub-feature-autoinject t))

The error seems to be the call to magithub-pull-requests-list here

[vermiculus]

I guess my first question would be 'is magithub-pull-requests-list getting defined in time to be used?' Perhaps an autoload cookie is needed -- and as a workaround you could just require the package in your :config form.

By the way, you might take a look at switching to Forge! It's got much more inertia behind it IMO as a first-class citizen in Magit (being developed by its maintainer). There are some things Magithub can still do that Forge can't (like displaying CI status, if memory serves), but I suspect there are other solutions for this as well out there.

Truth be told, I'm more likely to make further contributions to Forge rather than make enhancements here. My company is standing up a GitLab instance for our production code and I'm more likely to want to integrate with that in my day-to-day -- something Magithub is unlikely to be able to do (#81).

[seanhagen]

Switching to Forge seems straight-forward enough, I'll give that a shot!

If you're not going to be maintaining Magithub anymore, may I suggest putting the repo in read-only mode or putting a big "DEPRECATED: Please use Forge instead" banner at the top of the README? That way folks would (hopefully) get the message they should be using Forge instead :smile:

[vermiculus]

done 😄