vermiculus / sx.el

Stack Exchange for Emacs
http://stackapps.com/q/3950
709 stars 40 forks source link

Add specific key face for headers #285

Closed thomasf closed 9 years ago

thomasf commented 9 years ago

Trying to implement a good solarized-theme matching other modes:

If you add a generic key face, author can use that.. Or add an author face if that works for you.

Compare to (mu4e) message mode:

image

vermiculus commented 9 years ago

What exactly do you mean by 'generic key face'? In the above screenshot, which pieces of text would count as such?

thomasf commented 9 years ago

The user name has the same color as "Author: " label which is not true for all other lines. If I didn't look too quickly they do have the same face applied to them. I want to emphasize value over it's label.

vermiculus commented 9 years ago

Region of interest.

Although it's interesting that our screenshot does not duplicate what you see:

though it may be out-of-date.

vermiculus commented 9 years ago

A describe-face on the author yields the header face – something has certainly changed since the screenshot posted.

thomasf commented 9 years ago

Hmm. I installed sx from melpa today.

vermiculus commented 9 years ago

Oh, no, that's not what I meant :) I mean the screenshot is out-of-date -- it displays the correct behavior, whereas the correct behavior is no longer exemplified in the actual code.

Malabarba commented 9 years ago

Thanks @thomasf, that was a bug. The sx-user-name face wasn't getting used. Since you're theming, other user-related faces to keep in mind are sx-user-reputation and sx-user-accept-rate (this last one isn't used ATM but probably will in the future).

thomasf commented 9 years ago

Thanks for the information