vermiculus / sx.el

Stack Exchange for Emacs
http://stackapps.com/q/3950
709 stars 40 forks source link

Error with Org 9.0: "Symbol's value as variable is void: org-store-link-functions" #324

Closed xuchunyang closed 7 years ago

xuchunyang commented 7 years ago

a description of what you are trying to do

M-x sx-tab-newest

the behavior you actually see

It doesn't work by reporting

eval-after-load: Symbol's value as variable is void: org-store-link-functions

in the message buffer.

steps we can take to reproduce the bug

Upgrade to org-mode 9.0 then M-x sb-tab-newest. The version I am using are:


https://github.com/vermiculus/sx.el/blob/87dfd1e2ce093d53c0919dac7899bbf06bd96224/sx-interaction.el#L230-L231 has

(eval-after-load "org"
  '(add-to-list 'org-store-link-functions #'sx-org-get-link))

but I don't find the org-store-link-functions variable in org 9.0 and it looks like be removed by this commit.

vermiculus commented 7 years ago

Confirmed; I can work on this tonight.

vermiculus commented 7 years ago

How does the above work for you?

xuchunyang commented 7 years ago

It works good: previous error is gone and org-store-link works like expected. I apply your patch and re-byte-compile sx-interaction.el.